From owner-svn-src-all@FreeBSD.ORG  Tue Apr 21 19:52:20 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.ORG
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 9C9EF1065672; Tue, 21 Apr 2009 19:52:20 +0000 (UTC)
Date: Tue, 21 Apr 2009 19:52:20 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Roman Divacky <rdivacky@FreeBSD.ORG>
Message-ID: <20090421195220.GA81212@FreeBSD.org>
References: <200904201819.n3KIJcZo054306@svn.freebsd.org>
	<20090421185436.GA18628@zim.MIT.EDU>
	<20090421190651.GA2505@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20090421190651.GA2505@freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r191330 - head/usr.bin/ncal
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2009 19:52:21 -0000

On Tue, Apr 21, 2009 at 09:06:51PM +0200, Roman Divacky wrote:
> On Tue, Apr 21, 2009 at 02:54:36PM -0400, David Schultz wrote:
> > Also, before this change, ncal was already full of convoluted
> > buffer handling, arbitrary buffer sizes, and little to no bounds
> > checking. This commit adds more magic numbers and fragile buffer
> > handling code, and generally makes an already hairy program even
> > less scrutable. This isn't your fault, but it would be nice if we
> > could make ncal better before it gets much worse. For instance,
> > you might use snprintf() or asprintf() instead of an extra half
> > dozen calls to memcpy() with various offsets.
> 
> yes, thats true. do you want me to revert this? I am perfectly fine
> with having locally modified cal that supports this highlighting
> and not share this with world at all.

As a matter of fact, it might be good idea.  Since the code is already
in repo, it can be revised later and committed again in its refined
form.

./danfe