From owner-cvs-all  Thu Jan  4 11: 9:59 2001
From owner-cvs-all@FreeBSD.ORG  Thu Jan  4 11:09:56 2001
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by hub.freebsd.org (Postfix) with ESMTP
	id F296637B402; Thu,  4 Jan 2001 11:09:54 -0800 (PST)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.9.3/8.9.3) id OAA61522;
	Thu, 4 Jan 2001 14:09:53 -0500 (EST)
	(envelope-from wollman)
Date: Thu, 4 Jan 2001 14:09:53 -0500 (EST)
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Message-Id: <200101041909.OAA61522@khavrinen.lcs.mit.edu>
To: Will Andrews <will@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/usr.bin/apply apply.c
In-Reply-To: <200101041905.f04J5ou82617@freefall.freebsd.org>
References: <200101041905.f04J5ou82617@freefall.freebsd.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

<<On Thu, 4 Jan 2001 11:05:49 -0800 (PST), Will Andrews <will@FreeBSD.org> said:

>   Use getusershell() to make sure the SHELL environment variable passed is
>   safe to use.  Add new option -s to allow anal users to pass things like
>   perl; this option is here along with getusershell() checking since the
>   such checking is only intended to affect things like suidperl that might
>   call apply(1).
  
What is the reason for this change?

I see no benefit in modifying many programs in this manner which do
not ordinarily run with elevated privileges.

It is the responsibility of those programs that do, to ensure that the
environment passed to their children is safe and sane.

-GAWollman



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message