From owner-svn-ports-head@freebsd.org  Tue Nov 28 16:21:33 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3180DBB6EE;
 Tue, 28 Nov 2017 16:21:33 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 45EED6BD73;
 Tue, 28 Nov 2017 16:21:32 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 2f342ccf
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Tue, 28 Nov 2017 09:21:26 -0700 (MST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
Subject: Re: svn commit: r455055 - head/devel/gitlab-shell
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <20171128161410.GA43542@FreeBSD.org>
Date: Tue, 28 Nov 2017 09:21:24 -0700
Cc: Torsten Zuehlsdorff <tz@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <29D836DC-C480-4E67-A468-0B13F9AF4008@adamw.org>
References: <201711281611.vASGBiI9055680@repo.freebsd.org>
 <20171128161410.GA43542@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
X-Mailer: Apple Mail (2.3445.4.7)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2017 16:21:34 -0000

> On 28 Nov, 2017, at 9:14, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
>=20
> On Tue, Nov 28, 2017 at 04:11:44PM +0000, Torsten Zuehlsdorff wrote:
>> New Revision: 455055
>> URL: https://svnweb.freebsd.org/changeset/ports/455055
>>=20
>> Log:
>>  devel/gitlab-shell: Update from 5.3.1 to 5.9.3
>>=20
>>  Changelog: =
https://gitlab.com/gitlab-org/gitlab-shell/blob/v5.9.3/CHANGELOG
>>=20
>>  Submitted by: Matthias Fechner <idefix@fechner.net>
>>=20
>> [...]
>> +LICENSE=3D	MIT
>> +
>=20
> Not mentioned and/or explained in the commit log.

A change in LICENSE deserves an explanation, but adding a LICENSE where =
there wasn=E2=80=99t one before is self-explanatory. =E2=80=9CAdd =
LICENSE=E2=80=9D in a commit message is no different from a LICENSE =
being added in the commit.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org