Date: Tue, 07 Apr 2015 09:19:18 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r281181 - head/usr.bin/sort Message-ID: <5523E766.8010904@FreeBSD.org> In-Reply-To: <CAF6rxgmFfEP1Zs7eQfc2MFB%2BrKFyubFg8qFT3VLExZiZFjd-Ng@mail.gmail.com> References: <201504070117.t371HTlS083981@svn.freebsd.org> <CAF6rxgmFfEP1Zs7eQfc2MFB%2BrKFyubFg8qFT3VLExZiZFjd-Ng@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/06/15 23:26, Eitan Adler wrote: > On 6 April 2015 at 21:17, Pedro F. Giffuni <pfg@freebsd.org> wrote: >> Author: pfg >> Date: Tue Apr 7 01:17:29 2015 >> New Revision: 281181 >> URL: https://svnweb.freebsd.org/changeset/base/281181 >> >> Log: >> sort(1): Cleanups and a small memory leak. >> >> Remove useless check for leading blanks in the month name. The >> code didn't adjust len after stripping blanks so even if a month >> *did* start with a blank we'd end up copying garbage at the end. >> Also convert a malloc + memcpy to strdup and fix a memory leak in >> the wide char version if mbstowcs() fails. >> Originally from Andre Smagin. >> >> Obtained from: OpenBSD (CVS rev. 1.2, 1.3) >> MFC after: 1 week > Thanks for porting all these cleanups! > I am not over, but they have started doing many unnecessary changes that I have no interest in. I am also wondering if we should give up the GNU behavior our sort(1) adopted. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5523E766.8010904>