From owner-dev-commits-src-main@freebsd.org Fri Jun 11 16:54:27 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 43F15661B03; Fri, 11 Jun 2021 16:54:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G1n4g1Mx7z3sM0; Fri, 11 Jun 2021 16:54:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1733A26699; Fri, 11 Jun 2021 16:54:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 15BGsRqT035568; Fri, 11 Jun 2021 16:54:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 15BGsQNi035567; Fri, 11 Jun 2021 16:54:26 GMT (envelope-from git) Date: Fri, 11 Jun 2021 16:54:26 GMT Message-Id: <202106111654.15BGsQNi035567@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: ab6145c97683 - main - style: tweak tab after #define advice MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ab6145c976833e4363f430143a16451b57cbf621 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 16:54:27 -0000 The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=ab6145c976833e4363f430143a16451b57cbf621 commit ab6145c976833e4363f430143a16451b57cbf621 Author: Warner Losh AuthorDate: 2021-06-11 16:33:04 +0000 Commit: Warner Losh CommitDate: 2021-06-11 16:54:06 +0000 style: tweak tab after #define advice Once upon a time, #define was cultural thing. However, even when it was promulgated, it was a minority usage. 20 years ago the split was 30k/69k (tab/space) and today the split is 80k/546k (tab/space). Update guidance to allow either with the usual suggestion to be consistent within a file. Reviewed by: sef, allenjude, 0mp (prior rev), jhb Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D30254 --- share/man/man9/style.9 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/share/man/man9/style.9 b/share/man/man9/style.9 index 10ca64cde817..9744b1c11a45 100644 --- a/share/man/man9/style.9 +++ b/share/man/man9/style.9 @@ -215,9 +215,9 @@ macros (ones that have side effects), and the names of macros for manifest constants, are all in uppercase. The expansions of expression-like macros are either a single token or have outer parentheses. -Put a single tab character between the +Put a single space or tab character between the .Ic #define -and the macro name. +and the macro name, but be consistent within a file. If a macro is an inline expansion of a function, the function name is all in lowercase and the macro has the same name all in uppercase. .\" XXX the above conflicts with ANSI style where the names are the