From owner-svn-ports-all@FreeBSD.ORG Mon Jun 23 18:30:55 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 67226FC1 for ; Mon, 23 Jun 2014 18:30:55 +0000 (UTC) Received: from mail-qa0-x22f.google.com (mail-qa0-x22f.google.com [IPv6:2607:f8b0:400d:c00::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0A5FC2621 for ; Mon, 23 Jun 2014 18:30:54 +0000 (UTC) Received: by mail-qa0-f47.google.com with SMTP id hw13so5961750qab.6 for ; Mon, 23 Jun 2014 11:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=qc1GJbabEL5Ipgrvn0hpdmTC7KvvXizR7H0xfvNEumQ=; b=rGsrcjOE3JYmrEmtn8ALv6pf1SFPWYubfFijO4BcJyXgptLjyfzdgo5q+2vqZzeX1u VCJvnslVY/Hc69c9goO7OwvwW2/4ifRlftizYDljT0macPL477zvKqx7y1mWh4ZpViQT xgMplS/1lXAvcbaAojVaHPOMoCB7QyyNyHOc4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=qc1GJbabEL5Ipgrvn0hpdmTC7KvvXizR7H0xfvNEumQ=; b=FMtVrxbNU8fSU0baCSNRve4viqwdSzg2JyU8AyYvQ9fNYksqhfk/jba5sQeNP8iVCH aUOjhh2Ah8L8ytnMEor/QlRQI6PO82t8MO1XI3g+OCpNGImF6AodUJXdD70JRA3VFYGa 2sWbvu36Dh7vVtVFJMFYzHnfVCSpLAkj4PcFus3hzBw9UTAFBokqk2r3TwG/aTQfI2OH sUwf4tUO6ZIGMvHVjXvPnzaD6I/cfMDJ+AhbgLyNSjPfDcV+ptGQXWqof7Nlkscdg4F9 ip7MpUO0bswxK4smFTq09gqo3CMGvNuRr1E9WpeiDfO4Nrjm07dalAOGyz0UbmJ5D09f khew== X-Gm-Message-State: ALoCoQnBMnJvJH5UuZEVumK6cFTIlyUvxtDXzyTSB/cZ+AIn6xdymMLfs5ScvYSMLSB5DXC3177D X-Received: by 10.224.7.6 with SMTP id b6mr35732972qab.45.1403548254148; Mon, 23 Jun 2014 11:30:54 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.222.131 with HTTP; Mon, 23 Jun 2014 11:30:24 -0700 (PDT) In-Reply-To: <20140623165459.GR23976@ivaldir.etoilebsd.net> References: <201406211708.s5LH8ZvE087036@svn.freebsd.org> <20140623124533.GP23976@ivaldir.etoilebsd.net> <20140623165459.GR23976@ivaldir.etoilebsd.net> From: Eitan Adler Date: Mon, 23 Jun 2014 11:30:24 -0700 X-Google-Sender-Auth: 8kne-dxodbr95zQlgVVRlfSYBsM Message-ID: Subject: Re: svn commit: r358722 - head/Mk To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 18:30:55 -0000 On 23 June 2014 09:54, Baptiste Daroussin wrote: > On Mon, Jun 23, 2014 at 09:37:25AM -0700, Eitan Adler wrote: >> On 23 June 2014 05:45, Baptiste Daroussin wrote: >> > On Sat, Jun 21, 2014 at 10:17:19AM -0700, Eitan Adler wrote: >> >> On 21 June 2014 10:08, Mathieu Arnold wrote: >> >> > Author: mat >> >> > Date: Sat Jun 21 17:08:34 2014 >> >> > New Revision: 358722 >> >> > URL: http://svnweb.freebsd.org/changeset/ports/358722 >> >> > QAT: https://qat.redports.org/buildarchive/r358722/ >> >> > >> >> > Log: >> >> > Add a small notice about maintainership of this file. >> >> > >> >> > With hat: portmgr >> >> > Sponsored by: Absolight >> >> > >> >> > Modified: >> >> > head/Mk/bsd.options.desc.mk >> >> > >> >> > Modified: head/Mk/bsd.options.desc.mk >> >> > ============================================================================== >> >> > --- head/Mk/bsd.options.desc.mk Sat Jun 21 17:03:33 2014 (r358721) >> >> > +++ head/Mk/bsd.options.desc.mk Sat Jun 21 17:08:34 2014 (r358722) >> >> > @@ -7,6 +7,8 @@ >> >> > # - OPTION_DESC?= must be 19 characters or less >> >> > # - OPTION description text must be 43 characters or less >> >> > # >> >> > +# - This file's MAINTAINER is ports@FreeBSD.org so that entries can be added to >> >> > +# it easily. Any sweeping changes should be approved by portmgr. >> >> >> >> IMHO this is silly. The risk of changing description text is almost >> >> zero. Sweeping changes should be reviewed, but I don't think gating >> >> the review on a member of portmgr is useful. >> >> >> > Given what happened recently on those yes portmgr needs to review those sweep >> >> I'll copy what I wrote on phabricator: >> >> If anything, the recent commits proved that this statement is exactly >> opposite of what it should be. >> >> People add entries too easily, not realizing that this file is just a >> default. This means that new entries are often too general or useless. >> >> Also, people are too discouraged to change the descriptions when they >> are useless. >> > That is your opinion other people have a different opinion here What value does portmgr add here over a peer review? What is the risk here? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams