From owner-cvs-all Tue Dec 4 6:17:11 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id BCD4837B405; Tue, 4 Dec 2001 06:16:39 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fB4EFqU78212; Tue, 4 Dec 2001 16:15:52 +0200 (EET) (envelope-from ru) Date: Tue, 4 Dec 2001 16:15:52 +0200 From: Ruslan Ermilov To: Dag-Erling Smorgrav Cc: Bill Fenner , Garrett Wollman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_mroute.c ip_output.c Message-ID: <20011204161552.E67698@sunbay.com> References: <200112011348.fB1DmGf07402@freefall.freebsd.org> <200112012051.fB1KpAp47152@khavrinen.lcs.mit.edu> <20011203114032.C60143@sunbay.com> <200112040151.RAA00166@windsor.research.att.com> <20011204103455.B26925@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Dec 04, 2001 at 12:50:42PM +0100, Dag-Erling Smorgrav wrote: > Ruslan Ermilov writes: > > This change did not eliminate "one test" actually, as the test was > > still done, and in the case of a match ip_output() just panic()ed. > > The test should be changed into a KASSERT, then. > DES, Please look at the actual code before replying. :-) The new code doesn't have this test at all, and simply uses the on-stack "struct route", if one wasn't supplied by a caller. I was just commenting on the change Garrett made in rev. 1.35. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message