Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Aug 2004 09:37:35 -0700
From:      Nate Lawson <nate@root.org>
To:        Don Lewis <truckman@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c
Message-ID:  <411A4B4F.6070007@root.org>
In-Reply-To: <200408100832.i7A8WmG4013169@gw.catspoiler.org>
References:  <200408100832.i7A8WmG4013169@gw.catspoiler.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Don Lewis wrote:
> On 10 Aug, Nate Lawson wrote:
> 
>>njl         2004-08-10 01:32:05 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/kern             kern_shutdown.c vfs_subr.c 
>>  Log:
>>  Skip the syncing disks loop if there are no dirty buffers.  Remove a
>>  variable used to flag the initial printf.
>>  
>>  Submitted by:   truckman (earlier version)
>>  
>>  Revision  Changes    Path
>>  1.162     +13 -5     src/sys/kern/kern_shutdown.c
>>  1.519     +1 -1      src/sys/kern/vfs_subr.c
> 
> 
> BDE had a number of objections to this patch.  This is the alternative
> that I came up with:

Feel free to rework/commit it.  I think your patch is a little rough 
still but generally think it's a good idea to reuse the check for nbufs.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?411A4B4F.6070007>