From nobody Thu Jan 15 14:50:55 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dsQsC2CWHz6P3xk for ; Thu, 15 Jan 2026 14:50:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dsQsC1Pslz3JD2 for ; Thu, 15 Jan 2026 14:50:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768488655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ajjwinlacYFGWmg+FVPPDmPANmby1DX4t013U1wGV/Q=; b=b0DuuYanFrZsiFo5cdmy3lXu6nXB5VfzDe6pbPdA2VXQwCpg2f29ERMgx8T4pchbj8RT7P lZ9/MQpCBaZGFMzri8gwB7ca0crvCaej84cwyr1DFoittmhAxw/ksfEFIy6EqTUq6kR17r UAGHay+9Io62ESXjsF383LEYkb28VctevPZJWgUKMXaNc8EvM1sPocCoULntlq//APOmW9 5WmxaFqnTWJQJC6r2UAmEDWoqKjWk1vDslQOSZ4LXBiQEUc0t+S819HOP6jRHTTGEwffr0 CzLN6n8uuDy0GS5wgJYyWQX5/OMvKzz1FVLbluF5bR8/uHGFHXznK/3D39VBMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768488655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ajjwinlacYFGWmg+FVPPDmPANmby1DX4t013U1wGV/Q=; b=UFh4JUohDqct8jvSwHV0FGLpIz0iOeEFym3VEoaDio+sbenxCBHQ7TEm0VdqWOQzYkNRjm 2s8tDt8trGOiL5ULysUPvpmTiP4GmXblhYwyv3HNx5mML0J90zEeSAkqzKnbIC54vtQBkn Sadrf3SmiidyRMELFqZ4g00CQ4Enf+ZD9YEQnrIeZKRF8WL4//9qAZneGkKypKLAPJoeq9 4ocmE/HR24F7AUM1WT0CE2J/QzDiXfhrNFPCmHfp3LL1U1Rc2bPmjJLWCT7fP7/z2Us7EA fDAApdHO7jGA9arD25Kj1MzCDZwonKrFeDUD3QChOKIjIZohy8fItjBo/5xBDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768488655; a=rsa-sha256; cv=none; b=iJBxwJp9LfHHTQSkgVluY0pPXoMPJd+aCZ/RT0qRJ4+mTdAprtk08qLBzyKKX40fPLCBzq lRQAlEoUxFx0cfcYnGfvstZmfgQ7W3AsBGobziurY26Qvml5L0rHPaK9/ENFOf0XpIQOZj O2Zzj7dXB4kRRYiTvQ+ZchzV0pr5OFXWMCIbE92o6yG0VsqN9z8AyGM+kLc64N+9km8brf fAaobaEfw+cBLKxoP5lpSIMp0kVXUAyF7eXZURC75xVhdwuZCPDg7gYwluvXv0R3n0y1bl xF4djSuJ1/S5yW/k5SntI73ktee2ZtarZNaQA2kOaT+TzU72OTpiV5iaDFTsaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dsQsC0vxYzYsj for ; Thu, 15 Jan 2026 14:50:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 231ae by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 15 Jan 2026 14:50:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrew Turner Subject: git: 6025e23a8f2f - stable/14 - pci/n1sdp: Disable HotPlug List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6025e23a8f2fca481e31436e3fa7a47fba5306d6 Auto-Submitted: auto-generated Date: Thu, 15 Jan 2026 14:50:55 +0000 Message-Id: <6968fecf.231ae.37cb50e9@gitrepo.freebsd.org> The branch stable/14 has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=6025e23a8f2fca481e31436e3fa7a47fba5306d6 commit 6025e23a8f2fca481e31436e3fa7a47fba5306d6 Author: Andrew Turner AuthorDate: 2025-10-17 15:02:19 +0000 Commit: Andrew Turner CommitDate: 2026-01-14 21:14:10 +0000 pci/n1sdp: Disable HotPlug Work around an issue when HotPlug is enabled where pcib3 and pcib5 continuously report the following: pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed ... As a workaround disable HotPlug on the N1SDP as it's unlikely anyone will depend on it. Reviewed by: br Fixes: 1f5c50a86173 ("pci_host_generic:Add pcib_request_feature on ACPI") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D53134 (cherry picked from commit edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0) --- sys/dev/pci/controller/pci_n1sdp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/dev/pci/controller/pci_n1sdp.c b/sys/dev/pci/controller/pci_n1sdp.c index b6f2b11dea05..4c8c04e6057f 100644 --- a/sys/dev/pci/controller/pci_n1sdp.c +++ b/sys/dev/pci/controller/pci_n1sdp.c @@ -345,6 +345,17 @@ n1sdp_pcie_write_config(device_t dev, u_int bus, u_int slot, bus_space_write_4(t, h, offset & ~3, data); } +static int +n1sdp_pcie_acpi_request_feature(device_t pcib __unused, device_t dev __unused, + enum pci_feature feature __unused) +{ + /* + * HotPlug isn't supported on the N1SDP as it causes an interrupt storm + */ + return (EINVAL); +} + + static device_method_t n1sdp_pcie_acpi_methods[] = { DEVMETHOD(device_probe, n1sdp_pcie_acpi_probe), DEVMETHOD(device_attach, n1sdp_pcie_acpi_attach), @@ -352,6 +363,7 @@ static device_method_t n1sdp_pcie_acpi_methods[] = { /* pcib interface */ DEVMETHOD(pcib_read_config, n1sdp_pcie_read_config), DEVMETHOD(pcib_write_config, n1sdp_pcie_write_config), + DEVMETHOD(pcib_request_feature, n1sdp_pcie_acpi_request_feature), DEVMETHOD_END };