From owner-freebsd-bugs@FreeBSD.ORG  Tue Apr 25 12:00:38 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2E15816A4D5
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 25 Apr 2006 12:00:38 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B1DD443D45
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 25 Apr 2006 12:00:37 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3PC0bKr037468
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 25 Apr 2006 12:00:37 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3PC0b7l037467;
	Tue, 25 Apr 2006 12:00:37 GMT (envelope-from gnats)
Date: Tue, 25 Apr 2006 12:00:37 GMT
Message-Id: <200604251200.k3PC0b7l037467@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
Cc: 
Subject: Re: kern/96242: rpcbind ignores NO_INET6=yes in make.conf
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jeremy Chadwick <freebsd@jdc.parodius.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Apr 2006 12:00:38 -0000

The following reply was made to PR kern/96242; it has been noted by GNATS.

From: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: Alex Kozlov <stalker@rm-rf.kiev.ua>
Cc: bug-followup@freebsd.org
Subject: Re: kern/96242: rpcbind ignores NO_INET6=yes in make.conf
Date: Tue, 25 Apr 2006 04:51:48 -0700

 On Mon, Apr 24, 2006 at 09:07:03AM +0300, Alex Kozlov wrote:
 > {snip patch}
 
 This patch works great.  I'd say go ahead and commit, but one thing
 to point out: style(9) says the following:
 
 Unary operators do not require spaces, binary operators do.  Do not use
 parentheses unless they are required for precedence or unless the state-
 ment is confusing without them.  Remember that other people may confuse
 easier than you.  Do YOU understand the following?
 
         a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1;
         k = !(l & FLAGS);
 
 That said, I'd recommend this instead:
 
 	if ( (nconf->nc_flag & NC_VISIBLE) &&
 		(strcmp(nconf->nc_protofmly, NC_INET6) != 0) )
 
 I'm being picky, of course... that's all.  :-)
 
 -- 
 | Jeremy Chadwick                                 jdc at parodius.com |
 | Parodius Networking                        http://www.parodius.com/ |
 | UNIX Systems Administrator                   Mountain View, CA, USA |
 | Making life hard for others since 1977.                             |