From owner-freebsd-current@FreeBSD.ORG Fri Dec 30 16:38:47 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16B2C16A41F for ; Fri, 30 Dec 2005 16:38:47 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9CA5C43D6E for ; Fri, 30 Dec 2005 16:38:35 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jBUGcWdJ015713; Fri, 30 Dec 2005 18:38:32 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 14149-12; Fri, 30 Dec 2005 18:38:30 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jBUGYYo7015642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 30 Dec 2005 18:34:34 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id jBUGYkG6042431; Fri, 30 Dec 2005 18:34:46 +0200 (EET) (envelope-from ru) Date: Fri, 30 Dec 2005 18:34:46 +0200 From: Ruslan Ermilov To: Matt Emmerton Message-ID: <20051230163446.GA41712@ip.net.ua> References: <03ac01c60d06$8b8b12b0$1200a8c0@gsicomp.on.ca> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <03ac01c60d06$8b8b12b0$1200a8c0@gsicomp.on.ca> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: freebsd-current@freebsd.org Subject: Re: Cleanup for config(8) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2005 16:38:47 -0000 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 30, 2005 at 01:01:55AM -0500, Matt Emmerton wrote: > Hi, >=20 > I've put together some patches to clean up some "loose ends" in the > config(8) code. > Detailed notes and patches are located here: > http://www.gsicomp.on.ca/projects/freebsd/config.html >=20 > Comments, criticisms and committers welcome. >=20 I've committed first patch almost intact. I've committed second patch with the following modifications except style: - finddev() and findopt() return a pointer; also use them in rmdev() and rmopt(). - didn't drop the "mandatory" directive; it's trivially implemented, someone may use it, and there's generally no sense in breaking API. - didn't commit a bug: in mkmakefile.c, "goto nextparam" should always be called regardless of whether DEVDONE was already set or not. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDtWGmqRfpzJluFF4RArOwAKCaIsoqfEcTFHZA+UUkrMG/tckeuQCeLh6J 4cnXvuCZlwPPkkFisKECQLg= =dHpF -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--