Date: Fri, 30 Dec 2005 18:34:46 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Matt Emmerton <matt@gsicomp.on.ca> Cc: freebsd-current@freebsd.org Subject: Re: Cleanup for config(8) Message-ID: <20051230163446.GA41712@ip.net.ua> In-Reply-To: <03ac01c60d06$8b8b12b0$1200a8c0@gsicomp.on.ca> References: <03ac01c60d06$8b8b12b0$1200a8c0@gsicomp.on.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 30, 2005 at 01:01:55AM -0500, Matt Emmerton wrote: > Hi, >=20 > I've put together some patches to clean up some "loose ends" in the > config(8) code. > Detailed notes and patches are located here: > http://www.gsicomp.on.ca/projects/freebsd/config.html >=20 > Comments, criticisms and committers welcome. >=20 I've committed first patch almost intact. I've committed second patch with the following modifications except style: - finddev() and findopt() return a pointer; also use them in rmdev() and rmopt(). - didn't drop the "mandatory" directive; it's trivially implemented, someone may use it, and there's generally no sense in breaking API. - didn't commit a bug: in mkmakefile.c, "goto nextparam" should always be called regardless of whether DEVDONE was already set or not. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDtWGmqRfpzJluFF4RArOwAKCaIsoqfEcTFHZA+UUkrMG/tckeuQCeLh6J 4cnXvuCZlwPPkkFisKECQLg= =dHpF -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051230163446.GA41712>