From owner-p4-projects@FreeBSD.ORG Fri Jun 4 23:30:45 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5A9A11065674; Fri, 4 Jun 2010 23:30:45 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1DE0D1065672 for ; Fri, 4 Jun 2010 23:30:45 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0C3F88FC15 for ; Fri, 4 Jun 2010 23:30:45 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o54NUimr060113 for ; Fri, 4 Jun 2010 23:30:44 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o54NUif6060111 for perforce@freebsd.org; Fri, 4 Jun 2010 23:30:44 GMT (envelope-from hselasky@FreeBSD.org) Date: Fri, 4 Jun 2010 23:30:44 GMT Message-Id: <201006042330.o54NUif6060111@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 179197 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2010 23:30:45 -0000 http://p4web.freebsd.org/@@179197?ac=10 Change 179197 by hselasky@hselasky_laptop001 on 2010/06/04 23:30:41 USB core: - add support for LOW speed BULK transfers. - this mode is not recommended by the USB 2.0 standard, though some USB devices use it anyway. Affected files ... .. //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#53 edit .. //depot/projects/usb/src/sys/dev/usb/controller/ohci.c#35 edit .. //depot/projects/usb/src/sys/dev/usb/controller/uhci.c#32 edit .. //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#177 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#53 (text+ko) ==== @@ -3792,9 +3792,7 @@ } break; case UE_BULK: - if (udev->speed != USB_SPEED_LOW) { - ep->methods = &ehci_device_bulk_methods; - } + ep->methods = &ehci_device_bulk_methods; break; default: /* do nothing */ ==== //depot/projects/usb/src/sys/dev/usb/controller/ohci.c#35 (text+ko) ==== @@ -2614,9 +2614,7 @@ } break; case UE_BULK: - if (udev->speed != USB_SPEED_LOW) { - ep->methods = &ohci_device_bulk_methods; - } + ep->methods = &ohci_device_bulk_methods; break; default: /* do nothing */ ==== //depot/projects/usb/src/sys/dev/usb/controller/uhci.c#32 (text+ko) ==== @@ -3068,9 +3068,7 @@ } break; case UE_BULK: - if (udev->speed != USB_SPEED_LOW) { - ep->methods = &uhci_device_bulk_methods; - } + ep->methods = &uhci_device_bulk_methods; break; default: /* do nothing */ ==== //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#177 (text+ko) ==== @@ -3057,7 +3057,7 @@ }; static const uint16_t bulk_min[USB_SPEED_MAX] = { - [USB_SPEED_LOW] = 0, /* not supported */ + [USB_SPEED_LOW] = 8, [USB_SPEED_FULL] = 8, [USB_SPEED_HIGH] = 512, [USB_SPEED_VARIABLE] = 512,