From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 18 11:31:15 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F257616A4CE for ; Fri, 18 Jun 2004 11:31:14 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EACD043D31 for ; Fri, 18 Jun 2004 11:31:14 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i5IBUZT6090558 for ; Fri, 18 Jun 2004 11:30:35 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5IBUZUe090557; Fri, 18 Jun 2004 11:30:35 GMT (envelope-from gnats) Date: Fri, 18 Jun 2004 11:30:35 GMT Message-Id: <200406181130.i5IBUZUe090557@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Poul-Henning Kamp" Subject: Re: misc/68074: devstat: disappearing devices not properly removed X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Poul-Henning Kamp List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2004 11:31:15 -0000 The following reply was made to PR misc/68074; it has been noted by GNATS. From: "Poul-Henning Kamp" To: Hendrik Scholz Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: misc/68074: devstat: disappearing devices not properly removed Date: Fri, 18 Jun 2004 13:28:00 +0200 In message <200406180713.i5I7DBTE001123@deimos.raisdorf.net>, Hendrik Scholz wr ites: >>Fix: > >devstat_remove_entry() gets called in sys/cam/scsi/scsi_ch.c, scsi_pass.c, >scsi_pt.c and scsi_sa.c but not in scsi_da.c and scsi_cd.c. >This patch adds the appropriate calls for disks and cdroms. I don't think this is the corrrect solution. scsi_da and scsi_ch are GEOM drivers and disk_destroy() should recover those devstat entries in due time. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.