From owner-cvs-src@FreeBSD.ORG  Fri Jun  8 13:54:22 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1848916A468;
	Fri,  8 Jun 2007 13:54:22 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id DF8DF13C487;
	Fri,  8 Jun 2007 13:54:21 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 5F56647105;
	Fri,  8 Jun 2007 09:54:21 -0400 (EDT)
Date: Fri, 8 Jun 2007 14:54:21 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Andrew Gallatin <gallatin@FreeBSD.org>
In-Reply-To: <200706081243.l58ChQnr045086@repoman.freebsd.org>
Message-ID: <20070608145333.G74809@fledge.watson.org>
References: <200706081243.l58ChQnr045086@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net pfil.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2007 13:54:22 -0000


On Fri, 8 Jun 2007, Andrew Gallatin wrote:

> gallatin    2007-06-08 12:43:26 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/net              pfil.h
>  Log:
>  Correct the definition of PFIL_HOOKED() so that it compares
>  the value of ph_nhooks to zero, not the address.  This removes
>  extranious calls to pfil_run_hooks (and an rw lock) from the
>  network stack's critical path when no pfil hooks are active.

Nice catch. :-)

I've not done a line-by-line KTR trace of all locking in the standard UDP and 
TCP input and output paths in a while, but I suspect such a thing is called 
for before 7.0 goes out the door in order to see what else has slipped in. 
It's generally a highly informative exercise.

Robert N M Watson
Computer Laboratory
University of Cambridge