From owner-cvs-all@FreeBSD.ORG  Fri Apr  8 00:53:29 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0E9031065673;
	Fri,  8 Apr 2011 00:53:29 +0000 (UTC)
	(envelope-from bf1783@googlemail.com)
Received: from mail-px0-f172.google.com (mail-px0-f172.google.com
	[209.85.212.172])
	by mx1.freebsd.org (Postfix) with ESMTP id C3F368FC12;
	Fri,  8 Apr 2011 00:53:28 +0000 (UTC)
Received: by pxi6 with SMTP id 6so2845020pxi.17
	for <multiple recipients>; Thu, 07 Apr 2011 17:53:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=gamma;
	h=domainkey-signature:mime-version:reply-to:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type;
	bh=Wp013qnY+ghZeyBKjjmkITWDouK/yVAvlkDbLQtfHUE=;
	b=h7+gAeiMAMRhvEtt0Fsz2DYzvQHNns9SsKonYov6a1z8niNEBmb/SfByCXvFFxEgUn
	PetuX2ITg4jeZ0Re3+rgER5wJzbi7aJyrycCghokOdHXiEb4Gm2mLGpz8L5x+1tfE1WX
	HuXQYv+1TMifAqsUesCAtp5e15gTtY4GsJUQU=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma;
	h=mime-version:reply-to:in-reply-to:references:date:message-id
	:subject:from:to:cc:content-type;
	b=hGP6ghzZyyvKZFqQhk1CR/14L2RQfjXA/kfwtY24hPPJxhsLh6W7/xQMc7aniFXORZ
	X7K5Nevp/vORy+ZXnMKvWDUuW3/9ZokfA9MfHgaNkfv0T/VaDK2N4LN/yfMTF/Ph8m/o
	+UPMWRcM8U8gVAkd98dGUn57Ark8JPTXTJxIY=
MIME-Version: 1.0
Received: by 10.142.195.12 with SMTP id s12mr1235062wff.307.1302224008069;
	Thu, 07 Apr 2011 17:53:28 -0700 (PDT)
Received: by 10.68.47.6 with HTTP; Thu, 7 Apr 2011 17:53:27 -0700 (PDT)
In-Reply-To: <201104072239.p37Md9oh031253@repoman.freebsd.org>
References: <201104072239.p37Md9oh031253@repoman.freebsd.org>
Date: Fri, 8 Apr 2011 00:53:27 +0000
Message-ID: <BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ@mail.gmail.com>
From: "b. f." <bf1783@googlemail.com>
To: Rene Ladan <rene@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/www/chromium Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: bf1783@gmail.com
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2011 00:53:29 -0000

On 4/7/11, Rene Ladan <rene@freebsd.org> wrote:
> rene        2011-04-07 22:39:09 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     www/chromium         Makefile
>   Log:
>   Cleanup Makefile a bit more:
>   - Convert two explicit dependencies to a USE_GNOME and USE_XORG component
>   - Use buildtime SSE2 detection instead of an OPTION

How is this last change above going to work for building i386
packages, if the package-building machine has SSE2, but other machines
that use the packages do not? (Or vice versa, for that matter.)  You
may add some sanity checks, and make the effect of the option
i386-specific, but I don't think that you can safely remove this
option entirely --  and the default setting has to allow packages to
work on all i386.

b.