Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Sep 2019 22:01:12 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r351799 - head/sys/conf
Message-ID:  <201909032201.x83M1C7p051412@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Tue Sep  3 22:01:12 2019
New Revision: 351799
URL: https://svnweb.freebsd.org/changeset/base/351799

Log:
  LOCAL_MODULES: Allow LOCAL_MODULES="" in src.conf to work
  
  Currently LOCAL_MODULES= works, but LOCAL_MODULES="" causes build errors as
  .for still has the empty string to loop over. An .if empty prior to the loop
  was considered, but LOCAL_MODULES has empty quotes at that point and thus,
  isn't empty. A better solution likely exists, but this floats us by for
  now...

Modified:
  head/sys/conf/kern.post.mk

Modified: head/sys/conf/kern.post.mk
==============================================================================
--- head/sys/conf/kern.post.mk	Tue Sep  3 21:11:04 2019	(r351798)
+++ head/sys/conf/kern.post.mk	Tue Sep  3 22:01:12 2019	(r351799)
@@ -77,10 +77,12 @@ modules-${target}:
 	    ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
 .endif
 .for module in ${LOCAL_MODULES}
+.if !empty(module)
 	@${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
 	@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
 	    DIRPRFX="${module}/" \
 	    ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
+.endif
 .endfor
 .endif
 .endfor



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909032201.x83M1C7p051412>