From owner-freebsd-ports-bugs@freebsd.org Thu Oct 5 15:13:47 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76EF9E3B023 for ; Thu, 5 Oct 2017 15:13:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 652A17576B for ; Thu, 5 Oct 2017 15:13:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v95FDk7a025298 for ; Thu, 5 Oct 2017 15:13:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 222779] New port: emulators/mgba, a Game Boy Advance emulator Date: Thu, 05 Oct 2017 15:13:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 15:13:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222779 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #1 from Tobias Kortkamp --- +.include + +.if ${PORT_OPTIONS:MDEBUGGERS} +USES+=3D libedit +.endif + +.if ${PORT_OPTIONS:MQT} +USE_QT5=3D qmake_build buildtools_build core gui widgets net= work opengl multimedia +USES+=3D desktop-file-utils +INSTALLS_ICONS=3D yes +.endif Hmm, all of these variables are settable via options helpers. I don't understand why you stopped using them here. +LDFLAGS+=3D -L/usr/local/lib # sqlite3 Using /usr/local directly like this is not correct (LOCALBASE can be set to other values by users). Use ${LOCALBASE} instead or better yet replace the whole thing by adding localbase:ldflags to USES +FFMPEG_DESC=3D FFmpeg video recording support +MAGICK_DESC=3D ImageMagick GIF recording support +QT_DESC=3D Qt frontend Please move all custom descriptions to after the OPTIONS_* section followed= by a section for the options helpers. Maybe rename QT->QT5. FFMPEG, MAGICK, QT5 already have descriptions in bsd.options.desc.mk. Do you need custom descriptions? https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-ord= er-options --=20 You are receiving this mail because: You are the assignee for the bug.=