From owner-svn-src-all@freebsd.org Thu Sep 20 16:39:27 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD04E10A2212; Thu, 20 Sep 2018 16:39:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 70CDE74543; Thu, 20 Sep 2018 16:39:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 959AB10B768; Thu, 20 Sep 2018 12:39:25 -0400 (EDT) Subject: Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src To: Mark Johnston , Matt Macy , jmd@freebsd.org References: <201807150023.w6F0NBx1065422@repo.freebsd.org> <20180920155402.GF99168@raichu> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: John Baldwin Message-ID: Date: Thu, 20 Sep 2018 09:39:24 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180920155402.GF99168@raichu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 20 Sep 2018 12:39:26 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 16:39:27 -0000 On 9/20/18 8:54 AM, Mark Johnston wrote: > On Sun, Jul 15, 2018 at 12:23:11AM +0000, Matt Macy wrote: >> Author: mmacy >> Date: Sun Jul 15 00:23:10 2018 >> New Revision: 336299 >> URL: https://svnweb.freebsd.org/changeset/base/336299 >> >> Log: >> msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd >> >> This corresponds to the latest status (hasn't changed in 9+ >> years) from openbsd of ld80/ld128 powl, and source cpowf, cpow, >> cpowl (the complex power functions for float complex, double >> complex, and long double complex) which are required for C99 >> compliance and were missing from FreeBSD. Also required for >> some numerical codes using complex numbered Hamiltonians. >> >> Thanks to jhb for tracking down the issue with making >> weak_reference compile on powerpc. >> >> When asked to review, bde said "I don't like it" - but >> provided no actionable feedback or superior implementations. >> >> Discussed with: jhb >> Submitted by: jmd >> Differential Revision: https://reviews.freebsd.org/D15919 > > This seems to have broken the gcc build: > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/ > > /workspace/src/lib/msun/ld80/e_powl.c:275:1: error: floating constant exceeds range of 'long double' [-Werror=overflow] > if( y >= LDBL_MAX ) > ^~ Which architecture? i386 doesn't get build with i386-xtoolchain-gcc pending some patches I haven't yet posted for review related to the weirdness we do with floating point on i386. -- John Baldwin