From owner-svn-src-all@freebsd.org Mon Feb 19 22:42:08 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23625F05AAF; Mon, 19 Feb 2018 22:42:08 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 87569707F6; Mon, 19 Feb 2018 22:42:07 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f46.google.com with SMTP id t79so1585445lfe.3; Mon, 19 Feb 2018 14:42:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1aUBe4GvRVzyhF30GXSS86cIP+MeXMGkRIUmAlWr2MY=; b=lDedTD1UZxvhaMu6Fr12KSzh5xBZL7tPfpYUyD1WfVp2kCNAx8MmqMMP9vAB49q5BV TcNw9vSS7oHtyxSBBfRUYKwmtI3sPjNr6PgTb8DdLC7JxmJNO5b1wa+YSs/ZDpnRUHYZ ZdJTvAyo+X+XPo9BeZZLdYvPkn1X398q6A+8Y38frX88+LnBqOJYORzTLP5AafnNFpYX scEJr4ynUDM+Vei7w3QOL5IUNKqRnzon+hBsELE+AApXGPQ+a2Vch7BhZ7owdRmVMrcu NLWEUqaghllYSfcafB047AdT1Xo++utyVrzjkm5RvKHwd0rukqB5xfiLp/DfGxGH9Pfz fPWg== X-Gm-Message-State: APf1xPB1uwU8U4Q5Rti6XAzVEjQJed7k0ntxKzv0GPCYs53SJ8xagB4l 4YKepQGWJ31HfTw9PBfhuThuhY+T X-Google-Smtp-Source: AH8x224m6Y4B1qp5LLN5TJ4N2J8LT6WSiRVw3hMW2q7teLfHkI/K/mOjjLbKqnWRHmO+SnNZVFk17A== X-Received: by 10.46.41.90 with SMTP id u87mr741771lje.112.1519080125514; Mon, 19 Feb 2018 14:42:05 -0800 (PST) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com. [209.85.215.46]) by smtp.gmail.com with ESMTPSA id 22sm2380731ljj.9.2018.02.19.14.42.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 14:42:05 -0800 (PST) Received: by mail-lf0-f46.google.com with SMTP id l191so1603660lfe.1; Mon, 19 Feb 2018 14:42:05 -0800 (PST) X-Received: by 10.25.143.27 with SMTP id r27mr11711224lfd.129.1519080125177; Mon, 19 Feb 2018 14:42:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.106.8 with HTTP; Mon, 19 Feb 2018 14:41:44 -0800 (PST) In-Reply-To: <1519079823.91697.30.camel@freebsd.org> References: <201802192229.w1JMTG9C082624@repo.freebsd.org> <1519079823.91697.30.camel@freebsd.org> From: Kyle Evans Date: Mon, 19 Feb 2018 16:41:44 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r329609 - head/stand/lua To: Ian Lepore Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 22:42:08 -0000 On Mon, Feb 19, 2018 at 4:37 PM, Ian Lepore wrote: > On Mon, 2018-02-19 at 22:29 +0000, Kyle Evans wrote: >> >> + -- Swap the first two menu entries >> + menu_entries[1], menu_entries[2] = menu_entries[2], >> + menu_entries[1]; >> > > IMO, this is the sort of unreadable insanity that comes from having > inflexible rules about line-wrapping which trump readability. The > original code could be easily understood. The suggested replacement, > > menu_entries[1], menu_entries[2] = > menu_entries[2], menu_entries[1] > > Was also pretty readable, although not as much as it would be if it > were all on one line. But splitting the line at the whitespace nearest > to 80 columns just creates an unreadable mess for the insignificant > virtue of following some arbitrary rule. (Which is why I very often > ignore that rule and split lines at the point < 80 which makes the most > sense for understanding the code, even if that means splitting at > column 30.) > Right, perhaps we should clarify this while the opportunity is ripe for style.lua(9) into something more like "80 columns are preferred, wrapping may occur much earlier than 80 columns." I blindly followed it here because we hadn't discussed any exception to it previously, but I think we're more likely in Lua to run into scenarios where the current guideline just isn't appropriate.