Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Apr 2020 12:38:40 +0200
From:      Adriaan de Groot <adridg@freebsd.org>
To:        Yuri Victorovich <yuri@freebsd.org>, Christoph Moench-Tegeder <cmt@burggraben.net>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r533086 - in head: graphics/pcl-pointclouds graphics/vv math/vtk8 math/vtk8/files science/avogadrolibs science/liggghts
Message-ID:  <5848464.b1Gf15ayfg@saskatoon.bionicmutton.org>
In-Reply-To: <20200427063322.GA87914@elch.exwg.net>
References:  <202004262204.03QM4APo012426@repo.freebsd.org> <20200427063322.GA87914@elch.exwg.net>

next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2445023.DmIDKN5qoo
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On 2020 prilula d. 27id 08:33:22 CEST Christoph Moench-Tegeder wrote:
> ## Yuri Victorovich (yuri@FreeBSD.org):
> > +post-install:
> > +	## 8.2 installs cmake files into a wrong location
> > +	#@cd ${STAGEDIR}${PREFIX} && \
> > +	#	${MV} lib/vtk-${VTK_SHORT_VER}/cmake lib/
> 
> The thought was great, but why did you comment this?
> Earlier vtk8 (8.1) installed it's cmake files in
> ${LOCALBASE}/lib/cmake/vtk-8.1/, now we've
> ${LOCALBASE}/lib/vtk-8.2/cmake/vtk-8.2 and e.g. opencascade can't
> find VTK. 



The litmus test should be if a plain find_package(VTK) -- at least, as plain 
as makes sense when finding VTK from a CMakeListstxt -- can find this one. It 
certainly looks unusual to have ${LOCALBASE}/<thing>/cmake/<thing>/ containing 
the CMake config files for <thing>.

I can't immediately tell from the documentation if find_package() looks there.

Note that it's not entirely unheard of -- zxing has lib/zxing/cmake rather 
than the more conventional lib/cmake/zxing.

[ade]
--nextPart2445023.DmIDKN5qoo
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEUq+pvuD+N8/vVW++WoDe9T7W/7IFAl6mtjAACgkQWoDe9T7W
/7KH7g/+LvDJzu3u2YJd1QeBkEK8MhZWQoc4AmuLSbWJVNspLXdM8864gnbu6sQy
bqkPHXW7g0tnQL92NBpuJSpM57k/tM4RdkMiDHbD8h/t8tWd2MK93oFdfoO5azSt
yhUgn561gARBYubNlam4Gn6XsAWJkdubXTPdTvS0GxpqVspS4NiWE0I3/exA/FMf
vvLr1umA3Lf5fMw+QAffQe0Awmtn1VJAiaPwUdNIXfS0ZKgbBDyujGJ76zNvwqsR
5YueRELhwgiXWorBihGL2b0eiqfGP73+9s2LxSKwQdo/9+uM9sbQ/podHZD8wdFg
bXAMsau/53ZiStN73qUPva1/5kJEOZuPENPOSXGcJpeXWmwjYFIMmSH356Dn2VBP
G0p0IyifklBx1gA7bgrgzwoU9yp5Ks29r2Lt2VZkybigQ/t6Na65tx2CxTc7Cdab
r/UL2h8IGUZ9Ooa7jNNrBTzvUef7KLs31TrES1APbn8oBhYG1PI1j7ozTEhGdnu5
JNBlrZrbUWg0J1E9qS4zblyT98Mscy1ijZUC9mxgVdbnuEAUIGKdebkrwim8Q/QI
F5DIRQk2Udv4E1XWpJtufF3/OqBtKwulDwQPw5BloTgDCPQu6lfFzu7NbcIt9P0Z
fuLINRucXflIh3QdacimSlPG1N9nLoHnKopa6x7tygxmh38Os9Y=
=zr5U
-----END PGP SIGNATURE-----

--nextPart2445023.DmIDKN5qoo--






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5848464.b1Gf15ayfg>