From owner-svn-ports-all@freebsd.org Mon Apr 27 10:38:50 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E2262B33CD; Mon, 27 Apr 2020 10:38:50 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from lb3-smtp-cloud8.xs4all.net (lb3-smtp-cloud8.xs4all.net [194.109.24.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.xs4all.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 499h8T21DGz3Kpm; Mon, 27 Apr 2020 10:38:49 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from saskatoon.bionicmutton.org ([IPv6:2001:985:ab38:1:820f:9596:fc91:d07b]) by smtp-cloud8.xs4all.net with ESMTP id T19xjcZW0lKa1T19yjeG2o; Mon, 27 Apr 2020 12:38:46 +0200 From: Adriaan de Groot To: Yuri Victorovich , Christoph Moench-Tegeder Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r533086 - in head: graphics/pcl-pointclouds graphics/vv math/vtk8 math/vtk8/files science/avogadrolibs science/liggghts Date: Mon, 27 Apr 2020 12:38:40 +0200 Message-ID: <5848464.b1Gf15ayfg@saskatoon.bionicmutton.org> Organization: KDE In-Reply-To: <20200427063322.GA87914@elch.exwg.net> References: <202004262204.03QM4APo012426@repo.freebsd.org> <20200427063322.GA87914@elch.exwg.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2445023.DmIDKN5qoo"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-CMAE-Envelope: MS4wfCh5O7sIZ17X1yRU2wtvbRLBm2NCCpfAiM2Sakrb6kI3n5G6iyimnp8KcFuHNJ1kDyGMllHEesgj9PwpA7WpcM6vR+ycBzk9kZPWX3AbglnKvNnmV4A6 WmDSdBAfQrNx5ThEv/TJbb+HaGpfMr8KEYBsQL1X2dhoRYp0KdHjABJNs8sTe4338u0WKlrlyEOe+Yg1gzgDkn6uoRZp20oZbOmmwQPd76ZJ679wUDJBQV9f IfQ6StQsvyY5d8ZYy+yVyt9RpY7Ev06PJZ3MzGzC24UDLbq6+XSOShhx33MJZtcjKldqo/pGKozSYLipYocYeBHDpdSaAmKCpFocbBYwdtS+AbxCo/VKNhs+ GbSQIhCdl0cur2ScOgNhS8c3l6YxVJjy4NCazAvPokvE3DJUJpU= X-Rspamd-Queue-Id: 499h8T21DGz3Kpm X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-0.57 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.72)[-0.716,0]; NEURAL_SPAM_LONG(0.15)[0.146,0]; ASN(0.00)[asn:3265, ipnet:194.109.0.0/16, country:NL] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2020 10:38:50 -0000 --nextPart2445023.DmIDKN5qoo Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On 2020 prilula d. 27id 08:33:22 CEST Christoph Moench-Tegeder wrote: > ## Yuri Victorovich (yuri@FreeBSD.org): > > +post-install: > > + ## 8.2 installs cmake files into a wrong location > > + #@cd ${STAGEDIR}${PREFIX} && \ > > + # ${MV} lib/vtk-${VTK_SHORT_VER}/cmake lib/ > > The thought was great, but why did you comment this? > Earlier vtk8 (8.1) installed it's cmake files in > ${LOCALBASE}/lib/cmake/vtk-8.1/, now we've > ${LOCALBASE}/lib/vtk-8.2/cmake/vtk-8.2 and e.g. opencascade can't > find VTK. The litmus test should be if a plain find_package(VTK) -- at least, as plain as makes sense when finding VTK from a CMakeListstxt -- can find this one. It certainly looks unusual to have ${LOCALBASE}//cmake// containing the CMake config files for . I can't immediately tell from the documentation if find_package() looks there. Note that it's not entirely unheard of -- zxing has lib/zxing/cmake rather than the more conventional lib/cmake/zxing. [ade] --nextPart2445023.DmIDKN5qoo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEUq+pvuD+N8/vVW++WoDe9T7W/7IFAl6mtjAACgkQWoDe9T7W /7KH7g/+LvDJzu3u2YJd1QeBkEK8MhZWQoc4AmuLSbWJVNspLXdM8864gnbu6sQy bqkPHXW7g0tnQL92NBpuJSpM57k/tM4RdkMiDHbD8h/t8tWd2MK93oFdfoO5azSt yhUgn561gARBYubNlam4Gn6XsAWJkdubXTPdTvS0GxpqVspS4NiWE0I3/exA/FMf vvLr1umA3Lf5fMw+QAffQe0Awmtn1VJAiaPwUdNIXfS0ZKgbBDyujGJ76zNvwqsR 5YueRELhwgiXWorBihGL2b0eiqfGP73+9s2LxSKwQdo/9+uM9sbQ/podHZD8wdFg bXAMsau/53ZiStN73qUPva1/5kJEOZuPENPOSXGcJpeXWmwjYFIMmSH356Dn2VBP G0p0IyifklBx1gA7bgrgzwoU9yp5Ks29r2Lt2VZkybigQ/t6Na65tx2CxTc7Cdab r/UL2h8IGUZ9Ooa7jNNrBTzvUef7KLs31TrES1APbn8oBhYG1PI1j7ozTEhGdnu5 JNBlrZrbUWg0J1E9qS4zblyT98Mscy1ijZUC9mxgVdbnuEAUIGKdebkrwim8Q/QI F5DIRQk2Udv4E1XWpJtufF3/OqBtKwulDwQPw5BloTgDCPQu6lfFzu7NbcIt9P0Z fuLINRucXflIh3QdacimSlPG1N9nLoHnKopa6x7tygxmh38Os9Y= =zr5U -----END PGP SIGNATURE----- --nextPart2445023.DmIDKN5qoo--