From nobody Wed Dec 3 23:19:59 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dMDBR5wTTz6J1p7 for ; Wed, 03 Dec 2025 23:19:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dMDBR3Mp3z3ZrC for ; Wed, 03 Dec 2025 23:19:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764803999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7TDjGhlevJ/4jqEgFpUreIFB4l/ar4PqOar42DcX1r0=; b=JgfzjUfo9kMycuKJsvFNIbx3hZvVpWdpwCD/cjkeMuGtME0CeWkBCfAV/JGgKhQfeCCTBI GGhVTgCkkV+npHCHMF8Afkxq6CBzFRYFyMBvQ1/jt0wsI8Q/rH1wJTzuwvQ+waza7J1hNt 1Al5nXUW3WLFb4hbozKSKk2SqdwX2FFd73iLtA26hLfayB2lhPAwfRcVOL1qEnBmyWXKSK bvTNAoPtIomjC8yB6PUXIjhNKbqDX7mmQVViYG6r0odWoLMu5teQlx9NXK3Ldw9gIxIkD9 rPuqsHGhlLYmZT9rycUO0waXtK71IXiPx7FgTuaZx4qWAs8BXKNmp4PBiglmog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764803999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7TDjGhlevJ/4jqEgFpUreIFB4l/ar4PqOar42DcX1r0=; b=fExhp6QPoc9rh+65qajOoHyVfImag7rcCgXcD0sST9vFCWSxiWWEY6Ke+rvn4v5NqlY8PJ BQJtKBdf+N9NBzIdUFOoE8YMJ/Uf8CET5cqUKqLN9ZSBt3VojhcIajYGKXtzvf5CW7TW77 cfd0uvg6LFvM05tVjKGBBgaZ2y9KvxpQXWpBO93O6P0JN5BXOmVKYjczYIiYf6ye63R3vt DVUOsbUgd0dEpGL7femZjWHQ4aWuRq6PZco1qQw/PfVRDlI8co2Dj9/sLzjKtQZ5BAspIv SXKm8fdYCK61Jlc1AKUEgI+1R5nuHwTGI5zz3frCDyQdOhVYn+0IOFgUdxuvVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764803999; a=rsa-sha256; cv=none; b=dbfP3rsMBFRFAGw960SxDCB/8oZXwL/eegPaVgtSMINq5rnNU6Bg0Ify7lv8SK1oqinurk gKVln5yaX7/AgL++4J4bI9Gsj/kON2cLLPSaZCRWtQ84Ce7XueT0GQzTQ0xlZumIihlk4R DtVmrMsHOnjXbGExFIhBHvpKws1xp3GAVaAzmNf9Pqq3VQtaxpWGpFSH/97NgoNbcaw6NK SlI8wmQcnAjubomFazMyhnTqg+g1POhLiMNbEQIvRncRYytld9NzQ+FhOLTJkAXM1INhZV xRMbUnhfbo9pUmxiMbD9HewaGn2MDHW67Qbytqox2Cu16qEmaDJra9FuJ00koA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dMDBR2v5yzxd5 for ; Wed, 03 Dec 2025 23:19:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e606 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 03 Dec 2025 23:19:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: ee18f8be2165 - main - tcp: don't set flowid in tcp_input() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ee18f8be21655c2d98c1c1bd4e081c366fa91c9a Auto-Submitted: auto-generated Date: Wed, 03 Dec 2025 23:19:59 +0000 Message-Id: <6930c59f.3e606.697bc870@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=ee18f8be21655c2d98c1c1bd4e081c366fa91c9a commit ee18f8be21655c2d98c1c1bd4e081c366fa91c9a Author: Gleb Smirnoff AuthorDate: 2025-12-03 23:15:45 +0000 Commit: Gleb Smirnoff CommitDate: 2025-12-03 23:19:44 +0000 tcp: don't set flowid in tcp_input() With dd0e6bb996dc setting it always on connect(2) and syncache always picking up the flowid from the incoming packet, any ESTABLISHED connection shall have the flowid already set. Reviewed by: tuexen, gallatin Differential Revision: https://reviews.freebsd.org/D53886 --- sys/netinet/tcp_input.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index 9014dd690764..0036a07384ae 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -923,37 +923,6 @@ findpcb: } INP_LOCK_ASSERT(inp); - if ((inp->inp_flowtype == M_HASHTYPE_NONE) && - !SOLISTENING(inp->inp_socket)) { - if (M_HASHTYPE_GET(m) != M_HASHTYPE_NONE) { - inp->inp_flowid = m->m_pkthdr.flowid; - inp->inp_flowtype = M_HASHTYPE_GET(m); -#ifdef RSS - } else { - /* assign flowid by software RSS hash */ -#ifdef INET6 - if (isipv6) { - rss_proto_software_hash_v6(&inp->in6p_faddr, - &inp->in6p_laddr, - inp->inp_fport, - inp->inp_lport, - IPPROTO_TCP, - &inp->inp_flowid, - &inp->inp_flowtype); - } else -#endif /* INET6 */ - { - rss_proto_software_hash_v4(inp->inp_faddr, - inp->inp_laddr, - inp->inp_fport, - inp->inp_lport, - IPPROTO_TCP, - &inp->inp_flowid, - &inp->inp_flowtype); - } -#endif /* RSS */ - } - } #if defined(IPSEC) || defined(IPSEC_SUPPORT) #ifdef INET6 if (isipv6 && IPSEC_ENABLED(ipv6) &&