From owner-freebsd-gecko@freebsd.org Fri Nov 17 18:01:50 2017 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 669A8DDFFB1 for ; Fri, 17 Nov 2017 18:01:50 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 501656F944 for ; Fri, 17 Nov 2017 18:01:50 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4F6F8DDFFB0; Fri, 17 Nov 2017 18:01:50 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F137DDFFAF for ; Fri, 17 Nov 2017 18:01:50 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2869A6F943; Fri, 17 Nov 2017 18:01:50 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 66C36188CA; Fri, 17 Nov 2017 18:01:49 +0000 (UTC) From: Jan Beich To: Francois Marier Cc: gecko@FreeBSD.org, =?utf-8?Q?Ren=C3=A9?= Ladan Subject: Re: Firefox 56 in FreeBSD: Safe Browsing API key required References: <7a098f0b-2412-5ea5-5378-eb36c68fee2a@mozilla.com> <1369fb5d-b860-ddd2-a8d0-196ce33b4efa@mozilla.com> Date: Fri, 17 Nov 2017 19:01:44 +0100 In-Reply-To: (Jan Beich's message of "Fri, 08 Sep 2017 10:42:09 +0200") Message-ID: <4lps-lr7b-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 18:01:50 -0000 Jan Beich writes: > Jan Beich writes: > >> Francois Marier writes: >> >>>>> I just verified your API key in a custom build of Firefox and it will >>>>> work for basic Safe Browsing V4 support as long as you don't set >>>>> MOZILLA_OFFICIAL. >>>> >>>> Doesn't seem to work, at least on firefox-56.0b6. >>> >>> We need to uplift https://bugzilla.mozilla.org/show_bug.cgi?id=1394053 >>> to Beta to fix this. >> >> OK, I'll wait but the patch in that bug isn't enough to fix the error. > > Thanks. I confirm, Safe Browsing v4 works fine in firefox-56.0b10. Not sure why Firefox 56 didn't switch to v4 but 57 atm doesn't work. Chromium 61 still warns about phishing pages, so the issue is probbaly not due to the API key quota. $ firefox -new-instance -profile $(mktemp -d) about:url-classifier https://testsafebrowsing.appspot.com/ listmanager: 17:00:01 GMT+0000 (UTC): checkForUpdates with https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST listmanager: 17:00:01 GMT+0000 (UTC): this.tablesData: { "googpub-phish-proto": { "updateUrl": "https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "gethashUrl": "https://safebrowsing.googleapis.com/v4/fullHashes:find?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "provider": "google4" }, "goog-malware-proto": { "updateUrl": "https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "gethashUrl": "https://safebrowsing.googleapis.com/v4/fullHashes:find?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "provider": "google4" }, "goog-unwanted-proto": { "updateUrl": "https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "gethashUrl": "https://safebrowsing.googleapis.com/v4/fullHashes:find?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "provider": "google4" }, "goog-badbinurl-proto": { "updateUrl": "https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "gethashUrl": "https://safebrowsing.googleapis.com/v4/fullHashes:find?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "provider": "google4" }, "goog-downloadwhite-proto": { "updateUrl": "https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "gethashUrl": "https://safebrowsing.googleapis.com/v4/fullHashes:find?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "provider": "google4" }, "goog-passwordwhite-proto": { "updateUrl": "https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "gethashUrl": "https://safebrowsing.googleapis.com/v4/fullHashes:find?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST", "provider": "google4" }, "base-track-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "mozstd-trackwhite-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "mozplugin-block-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "allow-flashallow-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "except-flashallow-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "block-flash-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "except-flash-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "block-flashsubdoc-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "except-flashsubdoc-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" }, "except-flashinfobar-digest256": { "updateUrl": "https://shavar.services.mozilla.com/downloads?client=Firefox&appver=57.0&pver=2.2", "gethashUrl": "https://shavar.services.mozilla.com/gethash?client=Firefox&appver=57.0&pver=2.2", "provider": "mozilla" } } listmanager: 17:00:01 GMT+0000 (UTC): existing chunks: except-flash-digest256;a:1494877265 test-harmful-simple;a:1 except-flashallow-digest256;a:1490633678 test-malware-simple;a:1 allow-flashallow-digest256;a:1490633678 test-phish-simple;a:1 test-block-simple;a:1 except-flashinfobar-digest256;a:1497379266 except-flashsubdoc-digest256;a:1490633678 base-track-digest256;a:1507148777 mozstd-trackwhite-digest256;a:1510861265 test-track-simple;a:1-2 test-unwanted-simple;a:1 test-trackwhite-simple;a:1 block-flashsubdoc-digest256;a:1496263270 mozplugin-block-digest256;a:1471849627 block-flash-digest256;a:1496263270 listmanager: 17:00:01 GMT+0000 (UTC): stateArray: ,, listmanager: 17:00:01 GMT+0000 (UTC): update request: { "tableList": "googpub-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto,goog-passwordwhite-proto", "tableNames": { "googpub-phish-proto": true, "goog-malware-proto": true, "goog-unwanted-proto": true }, "requestPayload": "CgkKB0ZpcmVmb3gaCggCEAIiAiACKAEaCggBEAIiAiACKAEaCggDEAIiAiACKAE=", "isPostRequest": false } listmanager: 17:00:01 GMT+0000 (UTC): makeUpdateRequestForEntry_: requestPayload CgkKB0ZpcmVmb3gaCggCEAIiAiACKAEaCggBEAIiAiACKAEaCggDEAIiAiACKAE= update: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST tablelist: googpub-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto,goog-passwordwhite-proto listmanager: 17:00:01 GMT+0000 (UTC): download error for googpub-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto,goog-passwordwhite-proto: 429