From owner-freebsd-net@FreeBSD.ORG Mon Jul 7 11:23:45 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 16B77797; Mon, 7 Jul 2014 11:23:45 +0000 (UTC) Received: from mail-la0-x231.google.com (mail-la0-x231.google.com [IPv6:2a00:1450:4010:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3C4412981; Mon, 7 Jul 2014 11:23:44 +0000 (UTC) Received: by mail-la0-f49.google.com with SMTP id gf5so2753353lab.36 for ; Mon, 07 Jul 2014 04:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=P3h6CFQrbRbCvtOYXQiDBDwDe1XajiNHEUnvWwi7//4=; b=Dus9AcyvUTwdkc0Ap8jghOEhAR8sFRGwL1gemS4bnSnnvze7NKUJP8A5wyVONiwqcE /MUGydn3bFuCcqDT5lRuDEMvO6iq5JUD0+jHwdBo7npCm/ZcbYyDGGGxxEt2A+QihbIl bJ9SalEuuBnkh1xTLiTTQS//2cYHsllEc7csfhINPnYub7LktxJKEUrj9pLxZBV5oKTc j1r5U9BdFqI+YoTRYe7V7PIKx3fhtGkNf1LwrXfB0DoiDMSHP/G9rls9ZAcq7+RbDdAi dOPDlMTCtLEyl6uiRw/vtb9nBCuIPx7TMhnscEaYTYwBkhfJH9W/YTvtTwt/sKtZ2iQj hnVQ== MIME-Version: 1.0 X-Received: by 10.112.42.45 with SMTP id k13mr992210lbl.88.1404732221265; Mon, 07 Jul 2014 04:23:41 -0700 (PDT) Sender: rizzo.unipi@gmail.com Received: by 10.114.177.234 with HTTP; Mon, 7 Jul 2014 04:23:41 -0700 (PDT) In-Reply-To: <453BA9EC-BB63-4258-8141-847F41315E1E@sarenet.es> References: <453BA9EC-BB63-4258-8141-847F41315E1E@sarenet.es> Date: Mon, 7 Jul 2014 13:23:41 +0200 X-Google-Sender-Auth: 2W30VX2wv15ne_yh00tN4dbSBL0 Message-ID: Subject: Re: Fix Emulex "oce" driver in CURRENT From: Luigi Rizzo To: Borja Marcos Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-net@freebsd.org" , freebsd-current , Stable Stable X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2014 11:23:45 -0000 On Mon, Jul 7, 2014 at 1:03 PM, Borja Marcos wrote: > > On Jul 1, 2014, at 10:24 PM, Luigi Rizzo wrote: > >> >> >> >> On Tue, Jul 1, 2014 at 8:58 PM, wrote: >> El 30.06.2014 18:36, Stefano Garzarella escribi=C3=B3: >> >> Hello, >> I had problems during some experiments with Emulex and "oce" driver in >> CURRENT. >> I found several bugs in the "oce" driver and this patch fixes them. >> >> At least with some cards, the driver simply does not work. It causes a p= anic when there is some traffic. >> >> The relevant bug report is here. >> >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D183391 >> >> The latest version available from the Emulex website works. But the vers= ion bundled with 9.3 and at least -STABLE (which is the same version bundle= d with -CURRENT) does cause panics on 10- and 9- >> >> i compared the code on the emulex website (10.0.747.0 ?) with the >> one in HEAD and it does not seem much different, but perhaps >> you have some other version in mind ? >> >> The bugs found by stefano exist also in the emulex version above. > > Anyway > > The "fixed" version is an instant panic when generating traffic (just use= iperf3). Version 10.0.747.0 does _not_ panic. we'll try to investigate, can you tell us more about the environment you us= e ? (FreeBSD version, card model (PCI id perhaps), iperf3 invocation line, interface configuration etc.) The main differences between 10.0.747.0 and the code in head (after our fix) is the use of drbr_enqueue/dequeue versus the peek/putback in the transmit routine. Both drivers still have issues when the link flaps because the transmit queue is not cleaned up properly (unlike what happens in the linux driver and all FreeBSD drivers for different hardware), so it might well be that you are seeing some side effect of that or other problem which manifests itself differently depending on the environment. 'instant panic' by itself does not tell us anything about what could be the problem you experience (and we do not see it with either driver). cheers luigi