Date: Fri, 15 Oct 2010 09:15:27 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: Pawel Jakub Dawidek <pjd@FreeBSD.org>, Alexander Motin <mav@freebsd.org>, Marcel Moolenaar <marcel@freebsd.org>, Konstantin Belousov <kib@freebsd.org>, freebsd-geom@freebsd.org Subject: Re: [RFC][patch] GPT recovering support Message-ID: <DED1396D-89AA-4217-9EAE-175750C47DE1@mac.com> In-Reply-To: <4CB8587F.3010401@yandex.ru> References: <4CB850CC.4040206@yandex.ru> <4CB8587F.3010401@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 15, 2010, at 6:34 AM, Andrey V. Elsukov wrote: > On 15.10.2010 17:02, Andrey V. Elsukov wrote: >> * deny any modifications of corrupt tables. Only recover and destroy >> allowed. > > Oops. "gpart destroy" needs to allow "gpart delete"... > So, maybe "gpart destroy" should be denied too? Deletion of a partition is the same as modifying the partition table. I would not allow deletion because it creates fuzziness in the interface. It's better to implement a force option to destroy that forces a scheme to be destroyed in a way that prevents undo. This allows you to (effectively) wipe sectors and start over. This is exactly what you want if you're stuck with a detected scheme that is corrupt to the point that you can't do anything with it. It would be good if you can list the corruption cases that are being handled and how you recover. While we need to be friendly to the GEOM flexibility, we do need to respect the GPT spec to the extend that we remain compatible. Thanks, -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DED1396D-89AA-4217-9EAE-175750C47DE1>