From owner-freebsd-python@freebsd.org Wed Apr 15 01:59:03 2020 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F0B92CF772 for ; Wed, 15 Apr 2020 01:59:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4925BH1Cd6z45Y0 for ; Wed, 15 Apr 2020 01:59:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1C3B82CF769; Wed, 15 Apr 2020 01:59:03 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1BB4C2CF768 for ; Wed, 15 Apr 2020 01:59:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4925BF51zCz45X5 for ; Wed, 15 Apr 2020 01:59:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4EC3BF50B for ; Wed, 15 Apr 2020 01:59:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03F1x0Rm030904 for ; Wed, 15 Apr 2020 01:59:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03F1x0Nu030903 for python@FreeBSD.org; Wed, 15 Apr 2020 01:59:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: maintainer-approval requested: [Bug 245629] textproc/py-sphinx: Update to 3.0.1 : [Attachment 213400] sphinx-v3.0.1-v1.8.5-PR.patch Date: Wed, 15 Apr 2020 01:58:59 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2020 01:59:03 -0000 Danilo G. Baio has asked freebsd-python mailing list for maintainer-approval: Bug 245629: textproc/py-sphinx: Update to 3.0.1 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245629 Attachment 213400: sphinx-v3.0.1-v1.8.5-PR.patch https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D213400&action=3Dedit --- Description --- Before applying the patch: $ svn cp textproc/py-sphinx textproc/py-sphinx18 $ svn patch sphinx-v3.0.1-v1.8.5-PR.patch Plan: - Repocopy textproc/py-sphinx to textproc/py-sphinx18, then upgrade it to 1= .8.5 (latest version from 1.8.X). This version supports Python 2 and 3. Add test target. - textproc/py-sphinx: Update to 3.0.1 Python 3 only, 3.5+ Add test target. Add new ports (PR's will be linked here) - Mk/Uses/python.mk: Add PY_SPHINX To use with flavors and not break ports with USES=3Dpython (all versions). Python >=3D3.5 --> textproc/py-sphinx (v3.0.1) Python < 3.5 --> textproc/py-sphinx18 (v1.8.5) All ports that uses sphinx were changed to use the new variable ${PY_SPHI= NX} in the dependency line, exceptions: * Ports that fails to build with sphinx 3.0.1 because of code.=20 They are pointing to textproc/py-sphinx18 directly. There aren't many ports. * Ports that don't know Python flavors. - Add several patches to fix sphinx consumers The most common issues are related with pkg-plist, the output files from sphinx changes between versions, I tried to keep ports generating it dynamically.=20 This will save our time in the future sphinx updates. Tests: mini exp-run on all consumers, 2412 ports (all flavors). textproc/py-sphinx18: make test: 4 failed, 1324 passed, 23 skipped, 487 warnings in 84.17 sec= onds test_correct_year[expect_date1] - tests/test_correct_year.py:37: AssertionErro test_ext_imgconverter - tests/test_ext_imgconverter.py:23: AssertionError test_text_definition_terms - tests/test_intl.py:268: AssertionError test_gettext_definition_terms - tests/test_intl.py:530: AssertionError textproc/py-sphinx: make test: 1 failed, 1432 passed, 29 skipped, 37 warnings in 97.99 seco= nds WARNING: convert command 'convert' cannot be run, check the image_converter setting needs to investigate, docutils, imagemagick related IMHO this is very reasonable result, if you compare them with the current version (which is not even working in the tree): textproc/py-sphinx (current version in the ports tree v1.6.5): make test: 2 failed, 188 passed, 9 skipped, 36 warnings, 956 error in 11.96 seconds But tests can certainly be improved in the following updates. Looking forward for your feedback. And if this patch is fine, I Would like to ask for an exp-run.