From nobody Mon Apr 20 15:07:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fzpky0XMLz6WlfK for ; Mon, 20 Apr 2026 15:07:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fzpkx6zYwz47Kv for ; Mon, 20 Apr 2026 15:07:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776697674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BV0mnhfUVNAEDI22nXLx89FU/s1kgbGocsKhkrBrht8=; b=E5vsdWjwaBGUo2+m1dVe5iYrWUZHNUG9c/fJzu9uN1S1IhW0BN1v/0F3jC8Zw3S8EAN5mg k5/XZMyxCAHKHslmfBcbKavLK4+08uifC37S4q1pM2mVpnnZ/agHMD0/Kq2ag3/gw90bDv M0mc2HhljBwDNgjzd7ywrwC99kT17+5RDaixxgBy8dLagfEC93SD1wDiJgcdq/g56pQu1D lFco4O3PVuNYEff0gENpfSvgzYTigC8/HgUoneGbEUUmSGAwkGXhpX5aYBTBfnjLDGtvQq DBEafvo/DfGp9RaPsQTS7TODQ9Z4YGlgLt/nP8hLq/I2D0XQ40vSUABoWjraUA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776697674; a=rsa-sha256; cv=none; b=UzUjsuyGOWt9/8RaevBgfXFJvOymnSz725tkAzU+xyn5hhu27W/ID0UJrP81cJ1i0PDUkk I8YPO4U+e0m3dJDchYggL+3OOA0LnVYNMLjigWG2ZmrQ6C1hZbbRvSW42m6iP8SjgcvUFw Slc43TNAGHvQzIrTiVg4e5I5Ir9CvDuuzemSrd9wNT4jcjdqHAs6mZ4DuoZk2ugpcNJhFy EreyF6McFAb+m4sZXzweXlTYcMbFFmJozh/P6jM4eRT2Gu1zbswSvu/o8DeMr+zd+E0Njg 6PS8H7/3kKkIKCSIL8OAr4KSBinXlaWN/idL+DJ4eM+Cg6Z+V1FgqN0AyPVKvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776697674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BV0mnhfUVNAEDI22nXLx89FU/s1kgbGocsKhkrBrht8=; b=apU5Zq2QmprYotWiOezY9Juh0m70O4mEn6xqihdlPTljC1ECl5bJDVfWhi/sSck13n93Oj gT6BhYR82ahUNl+O7hD3VFa+BlEqxFkgAwcQxr7lSg0ohHa4dQEjwmwSBO0A33tLzoHb2T /IVUlL0emmVqWyoeb9of/wK8NAXTOwXSHOGL6z0vkgDfA0Dci7aqf68e//Asy/LXlqE5KS N47Iuzs7jYyxYSfeyiUYNlM2OLiGlbNLl6BpNTVBu5j/c9EO04MV7Bre20v613F1x/KbuR iKloes5VqGaGW9E2VlWghZ1gmGMvPuhgYtZ9fiUfqyFbu9xfnBUO9MUz0KGsJA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fzpkx6SzCz12DJ for ; Mon, 20 Apr 2026 15:07:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2747b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 20 Apr 2026 15:07:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: d3d0466cae54 - main - tests/socket_afinet: Fix the bind_connected_port test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d3d0466cae546254c50c80cf3e0c060bbbbba53c Auto-Submitted: auto-generated Date: Mon, 20 Apr 2026 15:07:48 +0000 Message-Id: <69e64144.2747b.1db98791@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d3d0466cae546254c50c80cf3e0c060bbbbba53c commit d3d0466cae546254c50c80cf3e0c060bbbbba53c Author: Mark Johnston AuthorDate: 2026-04-20 15:07:20 +0000 Commit: Mark Johnston CommitDate: 2026-04-20 15:07:20 +0000 tests/socket_afinet: Fix the bind_connected_port test The test verifies that a socket can bind to a local address assigned by connect(2) to a different socket. It was however trying to bind to the wrong address, and the check of the result was inverted, so this went unnoticed. It also needs to set SO_REUSEADDR for this to succeed. Reported by: glebius MFC after: 1 week --- tests/sys/netinet/socket_afinet.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/sys/netinet/socket_afinet.c b/tests/sys/netinet/socket_afinet.c index cfa2c9aa1706..31c98f9bfdb1 100644 --- a/tests/sys/netinet/socket_afinet.c +++ b/tests/sys/netinet/socket_afinet.c @@ -513,6 +513,7 @@ bind_connected_port_test(const atf_tc_t *tc, int domain) struct sockaddr_in sin; struct sockaddr_in6 sin6; struct sockaddr *sinp; + socklen_t slen; int error, sd[3], tmp; bool res; @@ -553,16 +554,15 @@ bind_connected_port_test(const atf_tc_t *tc, int domain) sin6.sin6_addr = in6addr_loopback; error = connect(sd[1], sinp, sinp->sa_len); ATF_REQUIRE_MSG(error == 0, "connect failed: %s", strerror(errno)); - tmp = accept(sd[0], NULL, NULL); + slen = sinp->sa_len; + tmp = accept(sd[0], sinp, &slen); ATF_REQUIRE_MSG(tmp >= 0, "accept failed: %s", strerror(errno)); - ATF_REQUIRE(close(sd[0]) == 0); - sd[0] = tmp; /* bind() should succeed even from an unprivileged user. */ - res = child_bind(tc, SOCK_STREAM, sinp, 0, false); - ATF_REQUIRE(!res); - res = child_bind(tc, SOCK_STREAM, sinp, 0, true); - ATF_REQUIRE(!res); + res = child_bind_priv(tc, SOCK_STREAM, sinp, SO_REUSEADDR); + ATF_REQUIRE(res); + res = child_bind_unpriv(tc, SOCK_STREAM, sinp, SO_REUSEADDR); + ATF_REQUIRE(res); } /*