From owner-freebsd-dtrace@freebsd.org Mon Apr 11 17:59:15 2016 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2703CB0C6BF for ; Mon, 11 Apr 2016 17:59:15 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com [IPv6:2607:f8b0:400e:c00::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F229013AC for ; Mon, 11 Apr 2016 17:59:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf0-x236.google.com with SMTP id c20so128122354pfc.1 for ; Mon, 11 Apr 2016 10:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/18A6MdfpcdrR+pY6DI/BTU3zKErxzWdsbs9zwhn2Lc=; b=HAWF9mDTwfOwyICciBIqvDmm/XgfVPpp25dKXb3wbl/E6MOgOm9jVxcOlQoAtrikyQ CpQFf0XyOtOIbgaorMiqrdlnurRuGZJPzizySKZbJRyl/fqkFgqYEQxugBPovGLWx/Km pzQddXxPkeVtWj+XcRO3oVGm+pMKN1ZIRdbPCLmRMH+ZFZUzmITIcKC3zesdHEefUBdv e4TX93T3S0CgvVXoP+jUJtBbkOtlMRc4bmLCdRwC70iLCt8GQoyymVLKw+yJk35b+g1o VswUgcLwRv+6GamL9U5nw6WfhkF+9pAKgii44BReuxjjdb6WOD0LhUie60QZSm4co7GO 9AFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=/18A6MdfpcdrR+pY6DI/BTU3zKErxzWdsbs9zwhn2Lc=; b=cak911Eslt7tNFkYt+xzzRqWovwjXgH94kZvLODDF3hX/TZZo6Slrk1P5r+htntv5d BdKWFgmYYUVVdXhd0HC25oMYopWLpfvQn1Ei6XKspyQUk8s3bZSwe1OBh2Y550tr1T17 xHtf6RkA35YB9qi7J8ZBo0ZE0bo1gqeqpohQBgSbvs7+c6F0med7oauEoffOFJrAPnxl 5UDX8qAn2DB9I12QRePSbGPc0cTczSYZ6TRAEi9tKtsptjaOwoE35527xPwXRAzLpgfc sZh8nj/ajWC+1I6psv85OlX42mePzewCoNIrCJ2E5cs1czdB1Q4t//4FaBqKwM1auBoe Qmfg== X-Gm-Message-State: AD7BkJIQUW7CRQOuKDCdi/UFVj4Ub3am97PTL34rAyodtRr/dG8wd5PccBJQeI713tAFjw== X-Received: by 10.98.75.10 with SMTP id y10mr34563141pfa.32.1460397554562; Mon, 11 Apr 2016 10:59:14 -0700 (PDT) Received: from wkstn-mjohnston.west.isilon.com (c-67-182-131-225.hsd1.wa.comcast.net. [67.182.131.225]) by smtp.gmail.com with ESMTPSA id uu7sm19875331pac.40.2016.04.11.10.59.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Apr 2016 10:59:14 -0700 (PDT) Sender: Mark Johnston Date: Mon, 11 Apr 2016 11:02:16 -0700 From: Mark Johnston To: Jihyun Yu Cc: freebsd-dtrace@freebsd.org Subject: Re: [patch] Fix crash on userland fbt tracing Message-ID: <20160411180215.GA20803@wkstn-mjohnston.west.isilon.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 17:59:15 -0000 On Mon, Apr 11, 2016 at 07:05:01PM +0900, Jihyun Yu wrote: > How to reproduce crash (tested on 10.3) > > - Run `top` on a shell > > - List dtrace probes with following command: > dtrace -p `pgrep top` -ln 'pid$target::clear:entry {} > pid$target::clear:return {}' > > - Try to attach probes without specifing pid provider > # dtrace -p `pgrep top` -n '::clear:entry {} ::clear:return {}' > Assertion failed: (err == 0), file > /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace/common/dt_proc.c, > line 1131. > > > The crash is caused by a deadlock, and here's a fix. This was committed as r297827. Thanks!