From owner-freebsd-bugs  Thu Dec 13 17:20:16 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4347D37B416
	for <freebsd-bugs@hub.freebsd.org>; Thu, 13 Dec 2001 17:20:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id fBE1K1U09127;
	Thu, 13 Dec 2001 17:20:01 -0800 (PST)
	(envelope-from gnats)
Date: Thu, 13 Dec 2001 17:20:01 -0800 (PST)
Message-Id: <200112140120.fBE1K1U09127@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Lars Eggert <larse@ISI.EDU>
Subject: Re: misc/32490: umass support for ATAPI [with patch]
Reply-To: Lars Eggert <larse@ISI.EDU>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR misc/32490; it has been noted by GNATS.

From: Lars Eggert <larse@ISI.EDU>
To: freebsd-gnats-submit@FreeBSD.org, larse@ISI.EDU
Cc:  
Subject: Re: misc/32490: umass support for ATAPI [with patch]
Date: Thu, 13 Dec 2001 17:17:25 -0800

 This is an ALTERNATIVE patch that just adds the required quirks to 
 scsi_da.c, in case that's preferred. Either this or the original patch 
 work for me.
 
 Lars
 
 --- /usr/src/sys/cam/scsi/scsi_da.c     Sun Jul 29 17:48:20 2001
 +++ /usr/src/sys/cam/scsi/scsi_da.c     Mon Dec  3 14:52:55 2001
 @@ -246,6 +246,14 @@
                  /*quirks*/ DA_Q_NO_6_BYTE|DA_Q_NO_SYNC_CACHE
          },
          {
 +               /*
 +                * Pentax Optio 430 Digital Camera
 +                * (will probably also work for the Optio 330)
 +                */
 +               {T_DIRECT, SIP_MEDIA_REMOVABLE, "PENTAX", 
 "DIGITAL_CAMERA", "*"},
 +               /*quirks*/ DA_Q_NO_6_BYTE|DA_Q_NO_SYNC_CACHE
 +       },
 +       {
                  {T_OPTICAL, SIP_MEDIA_REMOVABLE, "FUJITSU", 
 "MCF3064AP", "*"},
                  /*quirks*/ DA_Q_NO_6_BYTE
          }
 --- /usr/src/sys/dev/usb/umass.c        Sat Jan  6 14:36:15 2001
 +++ /usr/src/sys/dev/usb/umass.c        Mon Dec  3 14:47:47 2001
 @@ -575,7 +575,7 @@
 
          dd = usbd_get_device_descriptor(udev);
 
 -#if 0
 +#if 1
          /* XXX ATAPI support is untested. Don't use it for the moment */
          if (UGETW(dd->idVendor) == USB_VENDOR_SHUTTLE
              && UGETW(dd->idProduct) == USB_PRODUCT_SHUTTLE_EUSB) {
 @@ -656,7 +656,7 @@
                  break;
          case USUBCLASS_SFF8020I:
          case USUBCLASS_SFF8070I:
 -#if 0
 +#if 1
                  /* XXX ATAPI support is untested. Don't use it for the 
 moment */
                  sc->proto |= PROTO_ATAPI;
                  break;
 
 -- 
 Lars Eggert <larse@isi.edu>               Information Sciences Institute
 http://www.isi.edu/larse/              University of Southern California
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message