Date: Tue, 30 Aug 2016 07:22:46 -0700 From: John Baldwin <jhb@freebsd.org> To: src-committers@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305032 - head/sys/dev/cxgbe Message-ID: <1531680.3M3PdubIRh@ralph.baldwin.cx> In-Reply-To: <201608292247.u7TMlEf3050457@repo.freebsd.org> References: <201608292247.u7TMlEf3050457@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, August 29, 2016 10:47:14 PM John Baldwin wrote: > Author: jhb > Date: Mon Aug 29 22:47:14 2016 > New Revision: 305032 > URL: https://svnweb.freebsd.org/changeset/base/305032 > > Log: > Use device_verbose() to undo device_quiet() when detaching from t[45]iovX. > > The device quiet flag is not automatically reset on detach, so it is > inherited by other device drivers (e.g. when switching a device driver > over to ppt for PCI pass through). Cope with this behavior by explicitly > marking the device verbose during detach so that the next driver can make > its own decision. > > Sponsored by: Chelsio Communications Even though device_quiet() is documented to work this way, I think it is probably worth considering changing this so it only affects a single attach/detach life cycle. That is, clearing the flag in device_detach() (but also handling device_probe() correctly since it is typically called during probe and if multiple drivers probe a device, you only want the behavior of the "winning" driver to be in effect when you call attach). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1531680.3M3PdubIRh>