From owner-freebsd-multimedia@freebsd.org Sun Feb 12 21:47:58 2017 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33F72CDC6EF for ; Sun, 12 Feb 2017 21:47:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 1DD0E1726 for ; Sun, 12 Feb 2017 21:47:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1D250CDC6EC; Sun, 12 Feb 2017 21:47:58 +0000 (UTC) Delivered-To: multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CCABCDC6E9 for ; Sun, 12 Feb 2017 21:47:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0C1D01725 for ; Sun, 12 Feb 2017 21:47:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1CLlvaY090149 for ; Sun, 12 Feb 2017 21:47:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-approval requested: [Bug 217051] [PATCH] multimedia/vlc: Build in C++11 mode by default : [Attachment 179920] Proposed patch Date: Sun, 12 Feb 2017 21:47:57 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2017 21:47:58 -0000 Raphael Kubo da Costa has asked multimedia@FreeBSD.org= for maintainer-approval: Bug 217051: [PATCH] multimedia/vlc: Build in C++11 mode by default https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217051 Attachment 179920: Proposed patch https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179920&action=3Dedit --- Description --- This is in preparation for the Qt 5.6.2 -> 5.7.1 update (bug 216797): Qt 5.7 requires C++11 support. VLC 2.2.4 has issues building in C++11 mode, so incorporate a few upstream commits to make things work, and adjust the atomics-related patches landed = in ports r416225, as including only with libc++ >=3D 3.8.0 leaves out FreeBSD 10.3. include/vlc_atomic.h is now closer to its git (post-2.2.4) version, in that we now have 3 possible conditions: 1. The header is included in C11 mode, in which case is inclu= ded. 2. The header is included by C code but we're not building in C11 mode, in which case some shims are defined. 3. The header is included by C++ code, so we can assume C++11 and just incl= ude . It will likely be possible to drop the changes once a new VLC version is released, as upstream has since started requiring C+11 and passes the appropriate flags to the compiler.