From owner-freebsd-net@FreeBSD.ORG  Tue Feb 26 13:38:43 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id D0F93C1B;
 Tue, 26 Feb 2013 13:38:43 +0000 (UTC)
 (envelope-from lstewart@freebsd.org)
Received: from lauren.room52.net (lauren.room52.net [210.50.193.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 83C28324;
 Tue, 26 Feb 2013 13:38:43 +0000 (UTC)
Received: from lstewart1.loshell.room52.net
 (ppp59-167-184-191.static.internode.on.net [59.167.184.191])
 by lauren.room52.net (Postfix) with ESMTPSA id 151BC7E88D;
 Wed, 27 Feb 2013 00:38:36 +1100 (EST)
Message-ID: <512CBADB.3050004@freebsd.org>
Date: Wed, 27 Feb 2013 00:38:35 +1100
From: Lawrence Stewart <lstewart@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:13.0) Gecko/20120613 Thunderbird/13.0
MIME-Version: 1.0
To: Andre Oppermann <andre@FreeBSD.org>
Subject: Bug in sbsndptr()
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
 autolearn=unavailable version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Feb 2013 13:38:43 -0000

Hi Andre,

A colleague and I spent a very frustrating day tracing an accounting bug
in the multipath TCP patch we're working on at CAIA to a bug in
sbsndptr(). I haven't tested it with regular TCP yet, but I believe the
following patch fixes the bug (proposed commit log message is at the top
of the patch):

http://people.freebsd.org/~lstewart/patches/misctcp/sbsndptr_mnext_10.x.r247314.diff

The patch should have no tangible effect to operation other than to
ensure the function delivers on the promise to return the closest mbuf
in the chain for the given offset.

I would appreciate a review and any thoughts.

Cheers,
Lawrence