From owner-svn-src-stable-11@freebsd.org Sun Mar 22 02:56:04 2020 Return-Path: Delivered-To: svn-src-stable-11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E7EC2746D7; Sun, 22 Mar 2020 02:56:04 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48lMb81N8mz3J1s; Sun, 22 Mar 2020 02:56:04 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 15D021EAD9; Sun, 22 Mar 2020 02:56:04 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 02M2u3dq022283; Sun, 22 Mar 2020 02:56:03 GMT (envelope-from asomers@FreeBSD.org) Received: (from asomers@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 02M2u3E3022282; Sun, 22 Mar 2020 02:56:03 GMT (envelope-from asomers@FreeBSD.org) Message-Id: <202003220256.02M2u3E3022282@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: asomers set sender to asomers@FreeBSD.org using -f From: Alan Somers Date: Sun, 22 Mar 2020 02:56:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r359207 - stable/11/usr.sbin/extattr X-SVN-Group: stable-11 X-SVN-Commit-Author: asomers X-SVN-Commit-Paths: stable/11/usr.sbin/extattr X-SVN-Commit-Revision: 359207 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 02:56:04 -0000 Author: asomers Date: Sun Mar 22 02:56:03 2020 New Revision: 359207 URL: https://svnweb.freebsd.org/changeset/base/359207 Log: MFC r356809: setextattr: Increase stdin buffer size to 4096 Extended attribute values can potentially be quite large. One test for ZFS is supposed to set a 200MB xattr. However, the buffer size for reading values from stdin with setextattr -i is so small that the test times out waiting for tiny chunks of data to be buffered and appended to an sbuf. Increasing the buffer size should help alleviate some of the burden of reallocating larger sbufs when writing large extended attributes. Submitted by: Ryan Moeller Sponsored by: iXsystems, Inc. Differential Revision: https://reviews.freebsd.org/D23211 Modified: stable/11/usr.sbin/extattr/rmextattr.c Directory Properties: stable/11/ (props changed) Modified: stable/11/usr.sbin/extattr/rmextattr.c ============================================================================== --- stable/11/usr.sbin/extattr/rmextattr.c Sun Mar 22 02:54:59 2020 (r359206) +++ stable/11/usr.sbin/extattr/rmextattr.c Sun Mar 22 02:56:03 2020 (r359207) @@ -104,7 +104,7 @@ mkbuf(char **buf, int *oldlen, int newlen) int main(int argc, char *argv[]) { -#define STDIN_BUF_SZ 1024 +#define STDIN_BUF_SZ 4096 char stdin_data[STDIN_BUF_SZ]; char *p;