From owner-svn-src-head@freebsd.org Wed Sep 4 01:10:41 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4DB22DF961; Wed, 4 Sep 2019 01:10:41 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670060.outbound.protection.outlook.com [40.107.67.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NQjq1QsGz4bxL; Wed, 4 Sep 2019 01:10:38 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4ft2nWCui/znrruL5qrTNqsRAEN+gXOZVePv7+ZE0jFxPSESqCdg5vYPaMQqCFdK+8KdTrAuZgvnQjBaDHtnlVkWYMqSv4JUiQDAHB61wZJDQOOzN1L30cbWlElNz8pcaUTgD1uHJxJbcghkvPNwSezXC/ex78fiqh9uRcNsFCn6JMldmhPpJLK+e2oTFVdkWavakpwefBUQl+Ev1RSByJjCSpxkYX3u1bboYj20eXDlrxxXyhP2BwZxoSvpdigX4G2+k455jaTjrtcJA41faBznIbpDxUDx3DGJD3n9uLke7hF2jZk3OTD8DoXEx/gjDQIY5ZTOeIky3JXGuRD3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p1P1Df6a1zS3R7bXd5MpiMyNVykmN4hwY+V/NrCKlq4=; b=EUIiTIVOPIpyWVIVKMX10QEV7PiGSjvpt89KzDBqX0BeLcrKnhxnFQL4x4uIJyADQew4QhrPIwbsLTNpKAM1Qdcmaac2PbnWA8s7fIlELeqTlgmR7dSQ5nyHN7uBT3TZ/I2d9LwPQO/KazjYgQNALqVkqwFmy6uYI+KDLX7oWERq5YgWMaytbDlZodlAEEo+XfJQZaiRj3qcfUDKU9SgqTV6oWjTDqbo7oqDfyU2e2s0d1eXKmu0IvOjEZa/SPcnMoHQvIQi32K8ImoVnxjHGLCI3ubc44BWbvyX4eds8d4JSJFFqhdHLFH3cNnUrx6HQxhlffHUlO2lhB/ADlwKWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YT1PR01MB2907.CANPRD01.PROD.OUTLOOK.COM (10.255.42.216) by YT1PR01MB3820.CANPRD01.PROD.OUTLOOK.COM (10.255.44.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19; Wed, 4 Sep 2019 01:10:36 +0000 Received: from YT1PR01MB2907.CANPRD01.PROD.OUTLOOK.COM ([fe80::4031:c693:f53a:9ce3]) by YT1PR01MB2907.CANPRD01.PROD.OUTLOOK.COM ([fe80::4031:c693:f53a:9ce3%7]) with mapi id 15.20.2199.021; Wed, 4 Sep 2019 01:10:36 +0000 From: Rick Macklem To: Shawn Webb , Brooks Davis CC: Mateusz Guzik , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Thread-Topic: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Thread-Index: AQHVYmLUllKC/tKt9E6khoYTgzc3/6catekw Date: Wed, 4 Sep 2019 01:10:36 +0000 Message-ID: References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> <20190903114740.gbzkeffdce3mkee2@mutt-hbsd>, <20190903142035.w7tuqow4impv6bkx@mutt-hbsd> In-Reply-To: <20190903142035.w7tuqow4impv6bkx@mutt-hbsd> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 462202c2-2fb1-485e-55eb-08d730d4b16f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YT1PR01MB3820; x-ms-traffictypediagnostic: YT1PR01MB3820: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(396003)(136003)(346002)(376002)(51914003)(189003)(199004)(186003)(33656002)(4326008)(6506007)(102836004)(53546011)(476003)(71190400001)(486006)(71200400001)(446003)(52536014)(11346002)(76176011)(966005)(81166006)(81156014)(229853002)(8936002)(305945005)(8676002)(478600001)(110136005)(46003)(7696005)(786003)(14444005)(5660300002)(256004)(14454004)(316002)(54906003)(74316002)(25786009)(66946007)(64756008)(76116006)(6436002)(66446008)(9686003)(53936002)(66476007)(66556008)(2906002)(6246003)(55016002)(99286004)(86362001)(6306002); DIR:OUT; SFP:1101; SCL:1; SRVR:YT1PR01MB3820; H:YT1PR01MB2907.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xR3VcksXF1dCzAHsM06saNpc2in39G6s+42uc8uBJtxqHdVFS2MRMK3O08QOSBFJniRcdawL2AryHG5SNq0/a7+838UWPkRJLN4OxVLkCWfUNp5x4NtUvVnllLSaDIBZ/cdLNieHEhP/2s8ojKBqU29tp1TFiTSCu5Eat7oKRJg2qSHzZdcV1epEAZBXdhIvHUyYxLQh2Z/x0X0HJJq3L+46K/DW5pEBucV3IDYnOnC1E3dfI/AkbZkhbtdOgYlxHxeWkvrNT9qXNV57U1+gnaY+aF5EYp0rTi6ufiWH94QBf0oSnS02LJy7n41od8QwOd5BsFye6oVOVTxAubW0xN95atEOEt212lDwqPcUxSWx9e+unyLvwo02ncqjGXG9N21d2XZsDqC7u858ixZBO2fWe6S9p8DpUhJt5PJg4uI= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 462202c2-2fb1-485e-55eb-08d730d4b16f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2019 01:10:36.3628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kE5kr3MHocaEEwsXJM6COh34kybi5fpOounsywe6K8xF3+jri8cwpoVgAK0KHqbkvn/1nkq+NiQhGhCLW2XWng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB3820 X-Rspamd-Queue-Id: 46NQjq1QsGz4bxL X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.60 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-5.47 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.952,0]; RCVD_IN_DNSWL_NONE(0.00)[60.67.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.21)[ipnet: 40.64.0.0/10(-3.54), asn: 8075(-2.47), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 01:10:41 -0000 Yea, I know this is a top post... Another reason for a separate commit is the case where the patch is going t= o be MFC'd. rick _______________________________________ From: owner-src-committers@freebsd.org o= n behalf of Shawn Webb Sent: Tuesday, September 3, 2019 10:20 AM To: Brooks Davis Cc: Mateusz Guzik; src-committers@freebsd.org; svn-src-all@freebsd.org; svn= -src-head@freebsd.org Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/c= ompat/freebsd32 sys/kern sys/sys On Tue, Sep 03, 2019 at 07:47:40AM -0400, Shawn Webb wrote: > On Tue, Sep 03, 2019 at 11:45:23AM +0000, Brooks Davis wrote: > > On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: > > > Hey Mateusz, > > > > > > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: > > > > Author: mjg > > > > Date: Tue Sep 3 04:16:30 2019 > > > > New Revision: 351729 > > > > URL: https://svnweb.freebsd.org/changeset/base/351729 > > > > > > > > Log: > > > > Add sysctlbyname system call > > > > > > > > Previously userspace would issue one syscall to resolve the sysct= l and then > > > > another one to actually use it. Do it all in one trip. > > > > > > > > Fallback is provided in case newer libc happens to be running on = an older > > > > kernel. > > > > > > > > Submitted by: Pawel Biernacki > > > > Reported by: kib, brooks > > > > Differential Revision: https://reviews.freebsd.org/D17282 > > > > > > > > Modified: > > > ... snip ... > > > > head/sys/sys/param.h > > > > > > ... snip ... > > > > > > > > > > > Modified: head/sys/sys/param.h > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 2019 (r3= 51728) > > > > +++ head/sys/sys/param.h Tue Sep 3 04:16:30 2019 (r3= 51729) > > > > @@ -60,7 +60,7 @@ > > > > * in the range 5 to 9. > > > > */ > > > > #undef __FreeBSD_version > > > > -#define __FreeBSD_version 1300044 /* Master, propagated to ne= wvers */ > > > > +#define __FreeBSD_version 1300045 /* Master, propagated to ne= wvers */ > > > > > > To an outsider, it seems that __FreeBSD_version tends to be bumped in > > > a separate commit. Am I remembering that right? > > > > It should be bumped in the same commit, but people forget or the bump > > they have in their review turns into a no-op because someone else does = a > > bump in the interim (the latter has bit me several times). > > Interesting. Thanks for the clarification! One thought for making the version bump a seperate commit is if the original commit needed to be reverted, the commit can be reverted wholesale (well, from the perspective of __FreeBSD_version) without worry of accidentally decrementing the version number to a prior value. That's my "need-more-caffeine" verbose way of saying "separating the version bump from the actual work allows for easier maintenance of the version number, helping ensure an always-increasing number." Sorry if I sound dry here. My ten-month-old puppy is tiring me out way faster than I can tire him out. Thanks, -- Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2