From owner-cvs-src@FreeBSD.ORG Thu Oct 7 23:22:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03F9B16A4CE; Thu, 7 Oct 2004 23:22:32 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id C12B243D48; Thu, 7 Oct 2004 23:22:31 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (adsl-64-171-187-209.dsl.snfc21.pacbell.net [64.171.187.209]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i97NMU1d030906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 7 Oct 2004 16:22:31 -0700 Message-ID: <4165CFB5.9050806@root.org> Date: Thu, 07 Oct 2004 16:22:29 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long References: <200410071621.i97GL3lu029620@repoman.freebsd.org> <20041007175206.GA82275@ns1.xcllnt.net> <4165C120.7040005@root.org> <4165C1EF.7020407@FreeBSD.org> In-Reply-To: <4165C1EF.7020407@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Warner Losh cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/sys pbioio.h src/sys/i386/isa pbio.csrc/sys/conf files.i386 src/sys/i386/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2004 23:22:32 -0000 Scott Long wrote: > Nate Lawson wrote: >> Marcel Moolenaar wrote: >>> On Thu, Oct 07, 2004 at 04:21:03PM +0000, Warner Losh wrote: >>> >>>> imp 2004-10-07 16:21:03 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/conf files.i386 sys/i386/conf NOTES >>>> Added files: >>>> sys/sys pbioio.h sys/i386/isa pbio.c Log: >>>> Port pbio to HEAD. >>> >>> I appreciate your speed, but don't you think that pbioio.h is pretty >>> MD given that the driver only exists on i386. Wouldn't >>> >>> be a better place? >> >> Also, I think our policy for both RELENG_4 and -current is new >> inb/outb in new drivers. The bus_space stuff is pretty easy to use so >> this isn't too bad a requirement. > > I agree that new code should _not_ be using unportable primitives unless > there is very good reason. FWIW, I plan to make vtophys(), > rman_get_virtual(), and other evil and i386-specific primitives very > hard to use in 6-CURRENT, and I will strongly oppose importing new > code that tries to abuse them. I was just hoping that 5.3 would pass > before people started testing the boundaries. Note that while my reply was to Marcel who replied to Warner, my comment was meant to be informative, not suggest either of them are responsible for implementing the fix. -- Nate