From owner-svn-src-all@FreeBSD.ORG Tue Feb 26 18:51:14 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E475B79E; Tue, 26 Feb 2013 18:51:14 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by mx1.freebsd.org (Postfix) with ESMTP id E50F718C0; Tue, 26 Feb 2013 18:51:13 +0000 (UTC) Received: by mail-wi0-f179.google.com with SMTP id ez12so5079285wid.6 for ; Tue, 26 Feb 2013 10:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=o0Dgv56Bs0MTBBC97rngr6PBxxuvxwY2J792oBLqUZQ=; b=JwJJgeV3b+RPznHMTKPf7Nk3hsiOnej75lB0lYHY3plvdBfaPJ99AeNkfgDJ026Uos U26P2aGrnId5git9pgwsSw4Bkh8jCyOC4wj1HVqCfflTDv9TmgUX71uaM6waZZz5JpJv 6e5pGxkhF3ZD1VBfxrL8X+fhFfvCDkK4yXZw/+FrJkMXyWOMG4OSzXOAH7d2eKFHJ5c1 aqmrQPmzUQGub3WkEnbNiWcvWufkyz/0GlaBTwHNcIX+DZAvDNvIvP3Br3VeOovKYaj6 3knFWPhLMSHmBJXH7fGWshLeCLxKD5jPkkq8aCrFlbeokMOa76HfiVVkXFMER6zF36qq y2pA== MIME-Version: 1.0 X-Received: by 10.194.62.170 with SMTP id z10mr28564266wjr.34.1361904671500; Tue, 26 Feb 2013 10:51:11 -0800 (PST) Sender: davide.italiano@gmail.com Received: by 10.180.105.197 with HTTP; Tue, 26 Feb 2013 10:51:11 -0800 (PST) In-Reply-To: <201302261335.38001.jhb@freebsd.org> References: <201302260213.r1Q2D2N1016801@svn.freebsd.org> <201302260941.52534.jhb@freebsd.org> <201302261335.38001.jhb@freebsd.org> Date: Tue, 26 Feb 2013 19:51:11 +0100 X-Google-Sender-Auth: ozRWSi6Josxuw9Na7wrIZN2XLPg Message-ID: Subject: Re: svn commit: r247300 - in head: sys/sys usr.bin/truss From: Davide Italiano To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2013 18:51:15 -0000 On Tue, Feb 26, 2013 at 7:35 PM, John Baldwin wrote: > On Tuesday, February 26, 2013 12:09:42 pm Davide Italiano wrote: >> On Tue, Feb 26, 2013 at 3:41 PM, John Baldwin wrote: >> > On Monday, February 25, 2013 9:13:02 pm Xin LI wrote: >> >> Author: delphij >> >> Date: Tue Feb 26 02:13:02 2013 >> >> New Revision: 247300 >> >> URL: http://svnweb.freebsd.org/changeset/base/247300 >> >> >> >> Log: >> >> Expose timespec and timeval macros when __BSD_VISIBLE is defined. This >> >> allows userland application to use the following macros: >> >> >> >> timespecclear, timespecisset, timespeccmp, timespecadd, >> >> timespecsub; >> >> >> >> timevalclear, timevalisset, timevalcmp. >> > >> > Why not fix truss to use the stock functions instead of keeping private >> > "unusual" versions? >> > >> > -- >> > John Baldwin >> >> time.h is already a mess in terms of namespace pollution, and this >> exposure might not help thing. >> Other details here: >> http://permalink.gmane.org/gmane.os.freebsd.architechture/15518 > > I think that is orthogonal. Even if this is reverted I think truss should > be changed to use the "normal" timespecsubt() macro rather than using a custom > one with a different argument order. > > -- > John Baldwin When I talked about "exposure" I referred about timeval/timespec macros(). I wasn't arguing about your proposed change. Sorry if it wasn't clear. -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare