From owner-freebsd-current@FreeBSD.ORG Sat Dec 3 02:16:54 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.ORG Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72A3916A41F for ; Sat, 3 Dec 2005 02:16:54 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [204.14.90.11]) by mx1.FreeBSD.org (Postfix) with SMTP id F1A4943D5F for ; Sat, 3 Dec 2005 02:16:52 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 69456 invoked by uid 399); 3 Dec 2005 02:16:50 -0000 Received: from unknown (HELO ?192.168.0.5?) (dougb@dougbarton.net@127.0.0.1) by 127.0.0.1 with SMTP; 3 Dec 2005 02:16:50 -0000 Message-ID: <43910010.2050702@FreeBSD.org> Date: Fri, 02 Dec 2005 18:16:48 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (Windows/20051025) MIME-Version: 1.0 To: Andrey Chernov , Doug Barton , freebsd-current@FreeBSD.ORG References: <200512022006.jB2K67AK078509@repoman.freebsd.org> <20051203004057.GA20872@nagual.pp.ru> <4390EFB6.3090307@FreeBSD.org> <20051203012324.GA34147@nagual.pp.ru> <4390F9A2.208@FreeBSD.org> <20051203020831.GA34619@nagual.pp.ru> In-Reply-To: <20051203020831.GA34619@nagual.pp.ru> X-Enigmail-Version: 0.93.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: src/etc rc rc.shutdown rc.subr src/etc/rc.d localpkg src/sys/sys param.h X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Dec 2005 02:16:54 -0000 Andrey Chernov wrote: > On Fri, Dec 02, 2005 at 05:49:22PM -0800, Doug Barton wrote: >> I'm sorry if I wasn't clear before, the only thing port authors need to do >> for properly functioning rc.d-style scripts is to install them as foo >> instead of foo.sh. I have attached an untested patch for apache13 that >> should do the trick, or at least show you what I have in mind. > > What you mean by "properly"? I mean scripts that already run with rc.subr. For example, there was a problem at one point in the past with scripts that looked mostly like rc.d scripts, but did not have all the right stuff. That's one of the reasons I chose the PROVIDE label to grep for new-style scripts. To put this more plainly, if your script is already running properly with rc.subr now, it should run just fine within the base rcorder. I'm sure that there are some edge cases that will cause problems, but those have to be fixed regardless. > Do you mean that scripts without .sh runs in > the subshell and not damage main shell? Yes, that's what I mean. Once again, sorry I wasn't clear. I've been staring at this for too long now. :) > Please look inside files/apache.sh, what it actually does, > before just simple installing it without .sh. I should have mentioned in my last message that I did take a quick look at the script itself, and didn't see anything that should be a problem, but as I said, this is all untested. When I have a chance, I will install apache on my scratch box and try it both ways, with the script installed as apache.sh, and as just apache. However, feel free to test it yourself first if you have the time. :) Doug