From owner-freebsd-current@FreeBSD.ORG Fri Mar 14 01:32:05 2008 Return-Path: Delivered-To: current@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 216A4106566B for ; Fri, 14 Mar 2008 01:32:05 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from mx-out-01.forthnet.gr (mx-out.forthnet.gr [193.92.150.104]) by mx1.freebsd.org (Postfix) with ESMTP id 7EA2B8FC18 for ; Fri, 14 Mar 2008 01:32:04 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from mx-av-02.forthnet.gr (mx-av.forthnet.gr [193.92.150.27]) by mx-out-01.forthnet.gr (8.13.8/8.13.8) with ESMTP id m2E1W26P000844; Fri, 14 Mar 2008 03:32:02 +0200 Received: from MX-IN-04.forthnet.gr (mx-in-04.forthnet.gr [193.92.150.163]) by mx-av-02.forthnet.gr (8.14.1/8.14.1) with ESMTP id m2E1W2Z1023918; Fri, 14 Mar 2008 03:32:02 +0200 Received: from kobe.laptop (adsl102-242.kln.forthnet.gr [77.49.109.242]) by MX-IN-04.forthnet.gr (8.14.2/8.14.2) with ESMTP id m2E1VrR6022257; Fri, 14 Mar 2008 03:31:54 +0200 Authentication-Results: MX-IN-04.forthnet.gr smtp.mail=keramida@ceid.upatras.gr; spf=neutral Authentication-Results: MX-IN-04.forthnet.gr header.from=keramida@ceid.upatras.gr; sender-id=neutral Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m2E1Vq54004622; Fri, 14 Mar 2008 03:31:52 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m2E1VqjD004621; Fri, 14 Mar 2008 03:31:52 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Fri, 14 Mar 2008 03:31:52 +0200 From: Giorgos Keramidas To: Mike Telahun Makonnen Message-ID: <20080314013152.GA3585@kobe.laptop> References: <20080202012707.GA1800@kobe.laptop> <1204809780.885.3.camel@sol> <20080306201905.GA11317@kobe.laptop> <20080311025333.GF2422@monkeyboy.local> <584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com> Cc: Gregory Shapiro , current@FreeBSD.Org Subject: Re: latest rc.subr breaks etc/rc.d/sendmail X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2008 01:32:05 -0000 On 2008-03-13 09:36, Mike Telahun Makonnen wrote: > On Tue, Mar 11, 2008 at 5:53 AM, Gregory Shapiro wrote: > > > Agreed. We should probably consult gshapiro about this, and just do it > > > if there's no objection. AFAIK, /etc/rc.d/sendmail is also used to > > > start alternative MTAs, so we can commit this patch for now, and think > > > about splitting /etc/rc.d/sendmail to something like: > > > > > > src/etc/rc.d/sendmail > > > src/etc/rc.d/sendmail-submit > > > src/etc/rc.d/sendmail-outbound > > > src/etc/rc.d/sendmail-msp-queue > > > > I'd be cool with this and more than happy to provide code review. > > The four scripts would all need the same sort of logic to disable > > conflicting options (e.g., don't start a submit agent if a full MTA is > > running). > > Can yoiu take a look at the following patch please? It splits out > rc.d/sendmail into its constituent parts. I've split out the logic to > sort out conflicting options and rebuild the aliases database into a > separate file in /etc/mail/sendmail.subr. The rc.d scripts simply call > the appropriate routines in this file. In addition I've kept > rc.d/sendmail but added the nostart keyword. Thanks Mike :-) This looks great, from a fast reading I did. I'll install it on my laptop and test it for a while. If I don't get back to you in 1-2 days, please ping me again. It's a relatively hectic week at work, so it may take a few rc.d/sendmail start/stop iterations before I can fully test this.