Date: Tue, 19 Jan 2016 15:55:53 -0500 From: Ryan Stone <rysto32@gmail.com> To: Adrian Chadd <adrian.chadd@gmail.com> Cc: Hans Petter Selasky <hps@selasky.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r294327 - in head/sys: dev/cxgb dev/cxgbe dev/e1000 dev/hyperv/netvsc dev/ixgbe dev/mxge netinet sys Message-ID: <CAFMmRNxDUzJLHyWna8H_BH1RHziHAPVfQzV65Sb-mHuWXXiZnA@mail.gmail.com> In-Reply-To: <CAJ-Vmo=vi5fdGzx6Z6%2BD5szrpf0jcaOe7a_9u-o0V7%2B9YkE6qw@mail.gmail.com> References: <201601191533.u0JFXSxf037804@repo.freebsd.org> <CAFMmRNz3uXim3H3-sGuBUBs45Jy8p260ywothgp4iFkUcnvnEw@mail.gmail.com> <569E6A38.8080108@selasky.org> <CAFMmRNx3zC=mz=TC2Aq5==a5vh0Fqzv1domrCL2uUHnjybZSkQ@mail.gmail.com> <CAJ-Vmoki0yCU-mmPGfrGyJ_ar_=KKkto_ioomo_Ri_HCWR70cg@mail.gmail.com> <569E909B.60506@selasky.org> <CAJ-Vmo=1vTmKnoM=wVX=vv99mnkW-Q2CKkxZUNTUBkw_CU6ahQ@mail.gmail.com> <569E9B66.1070200@selasky.org> <CAJ-Vmo=vi5fdGzx6Z6%2BD5szrpf0jcaOe7a_9u-o0V7%2B9YkE6qw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 19, 2016 at 3:23 PM, Adrian Chadd <adrian.chadd@gmail.com> wrote: > Sure, but TCP fragments and non-fragments can hash to different > values, so suddenly you get interleaved packets. > If the NIC is hashing fragments and non-fragments to different values, aren't we already potentially getting out-of-order packets? If the same stream is spread across multiple queues all bets are already off. I'm not sure that this change has made things significantly worse in this regard. > So hopefully the LRO code > handles seeing that hole in the TCP stream and will eject the whole > stream up. The LRO code is aware of sequence numbers and will not merge frames if there is a hole in the sequence numbers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNxDUzJLHyWna8H_BH1RHziHAPVfQzV65Sb-mHuWXXiZnA>