Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Jun 2010 23:03:25 +0000 (UTC)
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org
Subject:   svn commit: r209487 - releng/8.1/sys/geom/gate
Message-ID:  <201006232303.o5NN3PON006696@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pjd
Date: Wed Jun 23 23:03:25 2010
New Revision: 209487
URL: http://svn.freebsd.org/changeset/base/209487

Log:
  MFC r209262:
  
  r209186:
  
  BIO_DELETE contains range we want to delete and doesn't provide any
  useful data, so there is no need to copy it to userland.
  
  r209187:
  
  'unit' can be negative, so use signed type for it.
  
  Found by:	Coverity Prevent
  CID:		3731
  
  Approved by:	re (kensmith)

Modified:
  releng/8.1/sys/geom/gate/g_gate.c
Directory Properties:
  releng/8.1/sys/   (props changed)
  releng/8.1/sys/amd64/include/xen/   (props changed)
  releng/8.1/sys/cddl/contrib/opensolaris/   (props changed)
  releng/8.1/sys/contrib/dev/acpica/   (props changed)
  releng/8.1/sys/contrib/pf/   (props changed)
  releng/8.1/sys/dev/ixgbe/   (props changed)
  releng/8.1/sys/dev/xen/xenpci/   (props changed)
  releng/8.1/sys/geom/sched/   (props changed)

Modified: releng/8.1/sys/geom/gate/g_gate.c
==============================================================================
--- releng/8.1/sys/geom/gate/g_gate.c	Wed Jun 23 22:33:03 2010	(r209486)
+++ releng/8.1/sys/geom/gate/g_gate.c	Wed Jun 23 23:03:25 2010	(r209487)
@@ -210,7 +210,7 @@ g_gate_start(struct bio *bp)
 }
 
 static struct g_gate_softc *
-g_gate_hold(u_int unit, const char *name)
+g_gate_hold(int unit, const char *name)
 {
 	struct g_gate_softc *sc = NULL;
 
@@ -572,8 +572,8 @@ g_gate_ioctl(struct cdev *dev, u_long cm
 
 		switch (bp->bio_cmd) {
 		case BIO_READ:
-			break;
 		case BIO_DELETE:
+			break;
 		case BIO_WRITE:
 			error = copyout(bp->bio_data, ggio->gctl_data,
 			    bp->bio_length);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006232303.o5NN3PON006696>