From owner-svn-src-all@FreeBSD.ORG Mon Oct 22 16:10:29 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C850412E; Mon, 22 Oct 2012 16:10:29 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail.sippysoft.com (hub.sippysoft.com [174.36.24.17]) by mx1.freebsd.org (Postfix) with ESMTP id 97AE58FC12; Mon, 22 Oct 2012 16:10:29 +0000 (UTC) Received: from s173-180-43-49.bc.hsia.telus.net ([173.180.43.49] helo=[192.168.22.32]) by mail.sippysoft.com with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.80 (FreeBSD)) (envelope-from ) id 1TQKa7-000Dh9-4F; Mon, 22 Oct 2012 09:10:23 -0700 Message-ID: <50856FE9.1020807@FreeBSD.org> Date: Mon, 22 Oct 2012 09:10:17 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r241625 - head/usr.sbin/cron/cron References: <201210170044.q9H0iZHo055977@svn.freebsd.org> <20121017174814.GN35915@deviant.kiev.zoral.com.ua> <507F0FF8.3090602@FreeBSD.org> <20121017201811.GO35915@deviant.kiev.zoral.com.ua> In-Reply-To: <20121017201811.GO35915@deviant.kiev.zoral.com.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: sobomax@sippysoft.com X-ssp-trusted: yes X-Mailman-Approved-At: Mon, 22 Oct 2012 16:49:58 +0000 Cc: Ian Lepore , Adrian Chadd , src-committers@freebsd.org, Garrett Cooper , svn-src-all@freebsd.org, Pedro Giffuni , Bruce Evans , svn-src-head@freebsd.org, Xin Li X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 16:10:29 -0000 Guys, The latest version of the patch against current HEAD is available here: http://sobomax.sippysoft.com/cron.diff Any comments/suggestions are appreciated. This version should default to previous behaviour of waking up every 60 seconds unless there is @every_second entry in the cron. Konstantin, can you please put it for testing to your boxes? Please make sure to do `make clean' after applying it, as libcron is not listed as a dependency for cron, so it's possible that some changes may not be picked up. Thanks! -Maxim On 10/17/2012 1:18 PM, Konstantin Belousov wrote: > On Wed, Oct 17, 2012 at 01:07:20PM -0700, Maxim Sobolev wrote: >> On 10/17/2012 10:48 AM, Konstantin Belousov wrote: >>> The cron daemon in HEAD is not functional, i.e. no jobs are executed >>> at all. Reverting r241625 r241618 r241576 gives me the expected behaviour. >>> >>> P.S. I do not remember a single commit from you which did not failed on >>> tinderbox, or was not found buggy later. >> >> Should be fixed already in the latest HEAD. Please check and let me know >> if you still have some issues (send crontab entry which is not getting >> executed). The particular issue has been fixed in the r241618. > > Well, as I noted above, I had r241618 applied, since I needed to revert it. > For me, neither the standard entries from /etc/crontab, nor the following > user crontab: > * * * * * /usr/bin/limits -a >/tmp/1.txt > are not executing. In particular, the /tmp/1.txt file was not created, > and the cron.log was empty. > > As I said, a reversal of all three commits makes the cron(8) operate > correctly. >