From owner-freebsd-bugs@FreeBSD.ORG  Wed Dec  5 04:39:33 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4F12116A419;
	Wed,  5 Dec 2007 04:39:33 +0000 (UTC)
	(envelope-from qhwt+fbsd@les.ath.cx)
Received: from les.ath.cx (15.61.205.61.west.global.alpha-net.ne.jp
	[61.205.61.15])
	by mx1.freebsd.org (Postfix) with ESMTP id 12AA313C4E7;
	Wed,  5 Dec 2007 04:39:33 +0000 (UTC)
	(envelope-from qhwt+fbsd@les.ath.cx)
Received: by les.ath.cx (Postfix, from userid 1000)
	id 6F63486618; Wed,  5 Dec 2007 13:18:22 +0900 (JST)
Date: Wed, 5 Dec 2007 13:18:22 +0900
From: YONETANI Tomokazu <qhwt+fbsd@les.ath.cx>
To: remko@FreeBSD.org
Message-ID: <20071205041822.GA67287@les.ath.cx>
References: <200711051747.lA5HlP3l050792@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200711051747.lA5HlP3l050792@freefall.freebsd.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: mux@FreeBSD.org, freebsd-bugs@FreeBSD.org, jdp@polstra.com
Subject: Re: bin/117831: csup is incompatible WRT handling unknown RCS
	keywords
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2007 04:39:33 -0000

On Mon, Nov 05, 2007 at 05:47:25PM +0000, remko@FreeBSD.org wrote:
> Over to maintainer.
> http://www.freebsd.org/cgi/query-pr.cgi?pr=117831

Ok, obviously I overlooked at what's written in TODO file:

  BUGS:
		:
  - Add missing support for supfile keywords and add sanity checks for
    some of them.  Also, we're not supposed to choke on unknown keywords
    to stay in line with CVSup, which just ignores them in order to
    maintain compatibility with sup configuration files.

so the author had already identified this problem far before I poked at him.

IMHO, ignoring an unknown keyword(a newphrase) is just OK, as long as it
spews a warning.  As many existing RCS/CVS tools are designed to behave
this way anyway, one won't (can't) add a newphrase which requires older
applications to upgrade and support it to operate on the new repository
properly.