Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Aug 2018 19:18:59 +0000 (UTC)
From:      Eugene Grosbein <eugen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r337985 - stable/11/sys/dev/bge
Message-ID:  <201808171918.w7HJIxx9007681@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eugen
Date: Fri Aug 17 19:18:59 2018
New Revision: 337985
URL: https://svnweb.freebsd.org/changeset/base/337985

Log:
  MFC r336461: bge(4): disable MSI for BGE_ASICREV_BCM5784/BGE_CHIPREV_5784_AX
  found in some MacBook Pro.
  
  PR:		229727
  Reported by:	Stephan Neuhaus <sten@artdecode.de> and others
  Tested by:	Stephan Neuhaus <sten@artdecode.de>
  Approved by:	mav (mentor)

Modified:
  stable/11/sys/dev/bge/if_bge.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/bge/if_bge.c
==============================================================================
--- stable/11/sys/dev/bge/if_bge.c	Fri Aug 17 18:37:22 2018	(r337984)
+++ stable/11/sys/dev/bge/if_bge.c	Fri Aug 17 19:18:59 2018	(r337985)
@@ -3204,6 +3204,14 @@ bge_can_use_msi(struct bge_softc *sc)
 		    sc->bge_chiprev != BGE_CHIPREV_5750_BX)
 			can_use_msi = 1;
 		break;
+	case BGE_ASICREV_BCM5784:
+		/*
+		 * Prevent infinite "watchdog timeout" errors
+		 * in some MacBook Pro and make it work out-of-the-box.
+		 */
+		if (sc->bge_chiprev == BGE_CHIPREV_5784_AX)
+			break;
+		/* FALLTHROUGH */
 	default:
 		if (BGE_IS_575X_PLUS(sc))
 			can_use_msi = 1;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201808171918.w7HJIxx9007681>