From owner-cvs-sys Fri Jun 7 15:46:32 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA00700 for cvs-sys-outgoing; Fri, 7 Jun 1996 15:46:32 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id PAA00692; Fri, 7 Jun 1996 15:46:27 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id IAA06611; Sat, 8 Jun 1996 08:41:54 +1000 Date: Sat, 8 Jun 1996 08:41:54 +1000 From: Bruce Evans Message-Id: <199606072241.IAA06611@godzilla.zeta.org.au> To: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, nate@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/conf files.i386 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: sys/i386/conf files.i386 > Log: > Added index as a 'standard' file. It could be added as 'optional' for > ibcs2, but I felt it might be useful in other code as well at a later > point. You probably should have used strchr. index goes with rindex, but rindex isn't actually used in the [i386] kernel, and Lite2 has almost completed removing *index from user code. OTOH, using a non-STDC function has the advantage that the compiler won't silently replace it by a possibly-inferior builtin. This shouldn't be a problem for rindex/strchr since it should be rarely used. OTOH, using a non-STDC function has the advantage that gcc may replace it by a superior builtin :-). Bruce