From owner-cvs-src@FreeBSD.ORG Thu Oct 21 07:12:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5276816A4CE; Thu, 21 Oct 2004 07:12:22 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99C5B43D46; Thu, 21 Oct 2004 07:12:21 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9L7CKZi062927; Thu, 21 Oct 2004 10:12:20 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 15672-15; Thu, 21 Oct 2004 10:12:19 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9L7CB6I062907; Thu, 21 Oct 2004 10:12:14 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9L7BmPg046173; Thu, 21 Oct 2004 10:11:48 +0300 (EEST) (envelope-from ru) Date: Thu, 21 Oct 2004 10:11:48 +0300 From: Ruslan Ermilov To: Andre Oppermann Message-ID: <20041021071148.GA46126@ip.net.ua> References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> <41758BF6.5020909@freebsd.org> <41758DF2.D3C1BD26@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <41758DF2.D3C1BD26@freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinetin_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 07:12:22 -0000 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2004 at 11:58:10PM +0200, Andre Oppermann wrote: > Scott Long wrote: [...] > > This is interesting. Have you measured performance/latency with this > > new scheme? Is it still possible to compile IPDIVERT into the kernel > > and avoid the indirect calls? >=20 > IPDIVERT can hardly be called a performance/latency critical path. The > entire copyout of the packet to userland for nat'ing and copyin again > make the function pointer indirection such a small factor that it doesn't > make any difference whatsoever. >=20 Err. divert(4) sockets can also be accessed through the ng_ksocket(4) interface, in which case no userland-kernel copying takes place. So the performance does matter. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --T4sUOijqQbZv57TR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBd2E0qRfpzJluFF4RAttVAJkBN+xNuTuSrz/0LnKQB581uPavzgCgjlQQ OJDcsRfxOgRlEwkmWUNCXiM= =b24A -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--