From nobody Tue Apr 8 13:40:59 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZX6fh58qTz5sQJ2; Tue, 08 Apr 2025 13:41:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZX6fh1FNqz3DL5; Tue, 08 Apr 2025 13:41:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744119660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wWcMcHm73zWp9q6MpWbATexqyz+rU1RdYNt2vRoD4Ko=; b=hSbDnYLgZ3GraS+5AUwV7YuTNQNc8J2NT2xWhhexVrYZZq4fg05HwC4l0eElu+VNWZZBgG 90CvrAcRZlfiTqJouZDOJDazQ/6enWTTxxdgdKr8ChtkJ10lPaEmK8z9iZNOSybgl5zVet L6MDIoqGoGPoob8tI1O5vLof1bqKmlnQBUQoIfJ+wZfffEvQeC061lLXB64ka5He8F7Mwl /iJ++/PO5x5aOQXjaaL+RKLl36TEEPzx9edT5wIlETZ6XGvs1CVMdVKJ7mBaxlBdGlNEqF LrAUhC/QV3rSeIpevc7bl7Q1beid8X7pNOiWGipAwph1HXcqlyZgpCytI/Sy3A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744119660; a=rsa-sha256; cv=none; b=snQXIczUrHNNNbOoIgf4lERPbxnysrEkDWu987hOZZRgdlYCaQM516MRxEyl7R6F6ktP6L 32q1XHdxPt02hx83uGcGv1pIBdiwQhOpqScyJCSIcjnHZiWDzZlXOlcSWCjZvcOMptDCL0 1i3AfkC8WUo1poAhRRr3eKuwsXn2Q5KWIT6oaxK7IdQObsRi9Ghd5/DpzkLjJ4Vdl/0amT YHzKL4JblkKIyVax8SK5Qcd2cm9NRpWZ+0/+EI7ei4YLFOZitAdBfoWyjujIJpI11i3aka 7TGqWNC6J+mRmn7sUOTYTqV1Jy1e7RrvEnafZISaml7CjQUwxDojH1pNFYRdhg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744119660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wWcMcHm73zWp9q6MpWbATexqyz+rU1RdYNt2vRoD4Ko=; b=HRBAtB3Zm7kXd/q2lZnOZlUCKJEiAgCliFapRe9L0VK2KAtcQKehXXlg1msazmPlluCkOH GZY8M6c6jkGlGGqkgWpi+5805tVYDr8RazwFYyN4OS4oyL3XFqSyvbjabUwu9vLatHCMn0 7va9SsZHZb8sM5lSJWBoaCBwZaVGKX3w5Vm0zkEgsehXXgWCswr2vvlUKbgdx6ilrC/+hh ovhQtJrDm3bJRlyb/wrqMHICAHqy9HKEGR6F8O0sPeioWDp936rvvLtOm44FbEUi2c0KwZ OKWZ9KwUOmZQyRz8bXe3vbpuhH8YE4KLKAiucfqB8ZElDnQX1R4UUum/5Qwy2w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZX6fh0Z1JzbJd; Tue, 08 Apr 2025 13:41:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 538DexRi032351; Tue, 8 Apr 2025 13:40:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 538Dex3Z032348; Tue, 8 Apr 2025 13:40:59 GMT (envelope-from git) Date: Tue, 8 Apr 2025 13:40:59 GMT Message-Id: <202504081340.538Dex3Z032348@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 4af7f393ec9a - stable/14 - libsa: smbios: style(9): Entry point parsing comments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4af7f393ec9abbc0a55339f5eb34662db501b4fa Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=4af7f393ec9abbc0a55339f5eb34662db501b4fa commit 4af7f393ec9abbc0a55339f5eb34662db501b4fa Author: Olivier Certner AuthorDate: 2025-03-03 10:45:23 +0000 Commit: Olivier Certner CommitDate: 2025-04-08 13:38:26 +0000 libsa: smbios: style(9): Entry point parsing comments Move the comments so that lines stay of reasonable length. Remove comments that state the obvious. Reviewed by: markj MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49280 (cherry picked from commit a609592ddcdf4e33a5126ffcdd12e6a609078d4c) --- stand/libsa/smbios.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/stand/libsa/smbios.c b/stand/libsa/smbios.c index a203d222bc79..4faec8c3aa01 100644 --- a/stand/libsa/smbios.c +++ b/stand/libsa/smbios.c @@ -563,19 +563,27 @@ smbios_probe(const caddr_t addr) #ifdef HAS_SMBV3 if (isv3) { - smbios.length = SMBIOS_GET32(saddr, 0x0c); /* Structure Table Length */ - paddr = SMBIOS_GET64(saddr, 0x10); /* Structure Table Address */ - smbios.count = -1; /* not present in V3 */ - smbios.ver = 0; /* not present in V3 */ + /* Structure Table Length */ + smbios.length = SMBIOS_GET32(saddr, 0x0c); + /* Structure Table Address */ + paddr = SMBIOS_GET64(saddr, 0x10); + /* not present in V3 */ + smbios.count = -1; + /* not present in V3 */ + smbios.ver = 0; maj_off = 0x07; min_off = 0x08; } else #endif { - smbios.length = SMBIOS_GET16(saddr, 0x16); /* Structure Table Length */ - paddr = SMBIOS_GET32(saddr, 0x18); /* Structure Table Address */ - smbios.count = SMBIOS_GET16(saddr, 0x1c); /* No of SMBIOS Structures */ - smbios.ver = SMBIOS_GET8(saddr, 0x1e); /* SMBIOS BCD Revision */ + /* Structure Table Length */ + smbios.length = SMBIOS_GET16(saddr, 0x16); + /* Structure Table Address */ + paddr = SMBIOS_GET32(saddr, 0x18); + /* No of SMBIOS Structures */ + smbios.count = SMBIOS_GET16(saddr, 0x1c); + /* SMBIOS BCD Revision */ + smbios.ver = SMBIOS_GET8(saddr, 0x1e); maj_off = 0x06; min_off = 0x07; } @@ -588,8 +596,8 @@ smbios_probe(const caddr_t addr) smbios.ver = 0; } if (smbios.ver == 0) { - smbios.major = SMBIOS_GET8(saddr, maj_off);/* SMBIOS Major Version */ - smbios.minor = SMBIOS_GET8(saddr, min_off);/* SMBIOS Minor Version */ + smbios.major = SMBIOS_GET8(saddr, maj_off); + smbios.minor = SMBIOS_GET8(saddr, min_off); } smbios.ver = (smbios.major << 8) | smbios.minor; smbios.addr = PTOV(paddr);