From nobody Tue Jul 7 13:23:42 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gvhkk54dXz6dcj5 for ; Tue, 07 Jul 2026 13:23:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gvhkk2nkCz3d3l for ; Tue, 07 Jul 2026 13:23:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783430622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+QYXo3bsBR3dz/4GbHndr726CJUweZ8sKp1qHUfaOl4=; b=rRiudUyF642B8l70DGBY1XxO2Jz/9u7rBpQzzDB/LS2SczwF0ydgEA9ZQDNjOrih3Y0eeH hIboaLzaQnlgYRSb7EM2q9rOcKaoqhLGAGPFkxuzqAZanluMvJNSER9t5l8y2w9rqbf3iw mdMt69qWE0rVHADPyqwA5TwTTHpcpOWV/WXyvdpwk/ohwRc6obmeRZT0LQbndJus/AES58 08D5+VflUtkR4dX5Sg+eH5loEWaRQQFtp93Ne4mwzumFILXknS3isVGBwHPUA5rMD7t49r JHqHADMOu5msgWSYS+3d0P+fUGFfRhTcCHLjHXP2KO8aAyNuVNxoQ17v8SkiIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783430622; a=rsa-sha256; cv=none; b=TXYMkWKdXmmodCz4sUPf9mA90S4k8iAm1iorTkmz1oaRca+cv50w75aZw86a5EHCZTF8ii hUjE3kOr4GO4tS9GKomjDo7frppglYGl7dBkA+ZbnwLNBWx++w4mxZY3WwdoXaPkEtkVWS 1gfcs637uINxcxtdWCjZ90T6oZPY1B6nypyL8JqWrg3Jiz3jIo6RVPYpzN/XY3sfMt/T4n 908lorpY1x8XRCsT6lzO2Pgg/kTTxJ+J9z3sSeWxb2vWHuIpgu0CJ4JoZNCu+4USg20Cvy WAr6S2w4iYzEDz/zBDB4U2t9QgFkuZGOWY0uL5lzkki6q5KQucaeHjISJrCdcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783430622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+QYXo3bsBR3dz/4GbHndr726CJUweZ8sKp1qHUfaOl4=; b=g9Tlqc89oVIfTzS+8kglVrw2YvMU9mSTlsZWg/SgEAvEZQp45LucUqIEUMMOOC42uo+G6w R/YOXED0OWGEYJlyJL+0drnjpuXDYNEg+f2K+hSinh6Q2o+LyANC0q2UGY+yijbPqT9HS9 MsQ3gxwqZo6QD6Zqw/Y+EwgA1ZBwdlKozxOUlzQuWd+vPiGOMAX6dxFq9aCI/k6VgFKwXP OGd1ozb9pBBmBZxnlIWiF1TnOhjWS3Y9TWg7cI+roC2oT7wcqiKf8yQosam4Xacy27Lefr 6QaLaSCQYB5sFA7NKknHDgAWPvAKGtI5zYA2uxASr0piyFI5lxyVQhzuOicyIA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gvhkk1Kv5zd2s for ; Tue, 07 Jul 2026 13:23:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4234f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 07 Jul 2026 13:23:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Acesp25 From: Kristof Provost Subject: git: 3e3752ce73b7 - main - if_bridge: Remove unused disable parameter in bridge_stop List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3e3752ce73b75b8d1089eb09c8b63d4bdde46219 Auto-Submitted: auto-generated Date: Tue, 07 Jul 2026 13:23:42 +0000 Message-Id: <6a4cfdde.4234f.2ca24905@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=3e3752ce73b75b8d1089eb09c8b63d4bdde46219 commit 3e3752ce73b75b8d1089eb09c8b63d4bdde46219 Author: Acesp25 AuthorDate: 2026-06-21 01:34:50 +0000 Commit: Kristof Provost CommitDate: 2026-07-07 13:17:02 +0000 if_bridge: Remove unused disable parameter in bridge_stop The ```int disable``` parameter is included in the bridge_stop function signature but is not used in the function body. I had noticed this when tracing the driver's path while learning more about the ifnet library. This parameter originally appeared when importing the driver from NetBSD. However, the FreeBSD ifnet library no longer requires an if_stop function. Meaning that the function signature can be changed to only contain needed parameters for our bridge driver. Discussed with: freebsd-net@ mailing list Signed-off-by: Acesp25 Reviewed by: kp Pull-Request: https://github.com/freebsd/freebsd-src/pull/2290 --- sys/net/if_bridge.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c index de991b8464c0..792b2c952e7a 100644 --- a/sys/net/if_bridge.c +++ b/sys/net/if_bridge.c @@ -327,7 +327,7 @@ static void bridge_init(void *); static void bridge_dummynet(struct mbuf *, struct ifnet *); static bool bridge_same(const void *, const void *); static void *bridge_get_softc(struct ifnet *); -static void bridge_stop(struct ifnet *, int); +static void bridge_stop(struct ifnet *); static int bridge_transmit(struct ifnet *, struct mbuf *); #ifdef ALTQ static void bridge_altq_start(if_t); @@ -937,7 +937,7 @@ bridge_clone_destroy(struct if_clone *ifc, struct ifnet *ifp, uint32_t flags) BRIDGE_LOCK(sc); - bridge_stop(ifp, 1); + bridge_stop(ifp); ifp->if_flags &= ~IFF_UP; while ((bif = CK_LIST_FIRST(&sc->sc_iflist)) != NULL) @@ -1068,9 +1068,9 @@ bridge_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) (ifp->if_drv_flags & IFF_DRV_RUNNING)) { /* * If interface is marked down and it is running, - * then stop and disable it. + * then stop it. */ - bridge_stop(ifp, 1); + bridge_stop(ifp); } else if ((ifp->if_flags & IFF_UP) && !(ifp->if_drv_flags & IFF_DRV_RUNNING)) { /* @@ -2346,7 +2346,7 @@ bridge_init(void *xsc) * Stop the bridge interface. */ static void -bridge_stop(struct ifnet *ifp, int disable) +bridge_stop(struct ifnet *ifp) { struct bridge_softc *sc = ifp->if_softc;