From nobody Wed Feb 15 20:28:12 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH8mB3fbQz3rJKV for ; Wed, 15 Feb 2023 20:28:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH8mB1b3nz3Cmp for ; Wed, 15 Feb 2023 20:28:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52f.google.com with SMTP id w3so18643350edc.2 for ; Wed, 15 Feb 2023 12:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hlqB0K2mj5kyuu4r+ulE+FQEW18qMlLkI+r+KS+ULhs=; b=pJ6NRB4T/jvV/hLUB9GU66QkAK8VQhsxz2Y8X2dmm1jF4dM69ATt3UnjSVi0UFtf4I pKVjY0nZXT+YeUt9orZzFbWBs63z1OXBDqs13lEf/e8A4JFsuN2gvn4ULh6o6xvvvG4w 4xIxeAX17At6vY80CGNQ8IhsQwTAEtRQ+B0SV5YLOuXGs47xXuJF+L+JWUfpojHxajkQ yLYZkIZqXzZCnF8McsRgp0Jguxoxfq/tKAe5njSeyEmXj3g0DiTbpAJoM++XCaj/hW6p 9sRRaeEXpmEje5YgGa8Ii+wCTEke8w+NkoFb8TQgZ2vS44KE8Xew1feyoq613QzKNCc6 UISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hlqB0K2mj5kyuu4r+ulE+FQEW18qMlLkI+r+KS+ULhs=; b=7jMWKdzEJX3t7oLMLACMXM09oCfdtSdiSk+38Sjd/Y90q+FpmfR1R51CCLsX3X8ocG 320m0SIJwvz/Mho+4ctVvQbVS4JdaOp+qrpEOPYF6nBXDSorVPcryvcAJWFGPIpxtAwI aPOGzCqMNpXv+bqIiyrcBzbNGUYBB9cNh/Ut5IgOK+J5bRMTWaZmPqz3GMWCBQUNzVpI 4HDmeE5QDor4h7/qPpvjWD8IL0f66dOM32nhQBeNJ5LLqtNa2JQO7EyQovQI8+akgpRq /R4upqtXcK3WEJ99yNQuZbzAw1sdggEdPc1YImY0GZZGIJ3vF/NXKzZsmVnxr+MRL1eY fi7Q== X-Gm-Message-State: AO0yUKVtlk3hW0fe6HE2pfuQ004uCTeQbgPa9z4F4jz8d+AQtwXzXPjq tROhfiCOY79du2GpjpGOctHyxlJr0Tua+RHLPoyjUw== X-Google-Smtp-Source: AK7set+SefyyOoG+mCmdNftTVOIgTJESaOdmem9x4boXTsaIVjRaF7m5vaWSfAT/sKHp/kzIEbsUVgb0f1ErrlA8SOs= X-Received: by 2002:a17:906:94d8:b0:895:58be:964 with SMTP id d24-20020a17090694d800b0089558be0964mr1718755ejy.2.1676492903554; Wed, 15 Feb 2023 12:28:23 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Wed, 15 Feb 2023 13:28:12 -0700 Message-ID: Subject: Re: Build breakage with WITH_BEARSSL=1 To: =?UTF-8?Q?Mina_Gali=C4=87?= Cc: Gordon Bergling , FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000fc378b05f4c2eb78" X-Rspamd-Queue-Id: 4PH8mB1b3nz3Cmp X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000fc378b05f4c2eb78 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2023, 1:09 PM Mina Gali=C4=87 wrote: > Would be nice if we could get upstream to actually fix this, but i don't > even know how to submit bugs there=E2=80=A6 > Agreed. I didn't recall off of the top of my head, so I did the quick bandaid. Warner Mina Gali=C4=87 > > Try PkgBase: https://alpha.pkgbase.live/ > > > > > > > -------- Original Message -------- > On 15 Feb 2023, 17:07, Warner Losh < imp@bsdimp.com> wrote: > > > > > On Sun, Feb 12, 2023, 3:18 PM Warner Losh wrote: > >> >> >> On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: >> >>> Hi, >>> >>> I am currently seeing a build breakage when building -CURRENT with >>> WITH_BEARSSL=3D1. >>> >>> The error is the following >>> >>> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: >>> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.as= c 2> >>> /dev/null" returned non-zero status >>> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error= : >>> a function declaration without a prototype is deprecat ed in all versi= ons >>> of C [-Werror,-Wstrict-prototypes] >>> br_rsa_i62_keygen_get() >>> ^ >>> void >>> 1 error generated. >>> --- rsa_i62_keygen.pico --- >>> >>> >>> When disabling BEARSSL in the src.conf the build succeeds as usual. >>> >>> Has anyone also seen this build error. Sources are very recent and the >>> src.conf is the following: >>> >>> WITH_EXTRA_TCP_STACKS=3D1 >>> #WITH_BEARSSL=3D1 >>> WITH_PIE=3D1 >>> WITH_RETPOLINE=3D1 >>> WITH_INIT_ALL_ZERO=3D1 >>> WITH_OPENSSL_KTLS=3D1 >>> WITHOUT_CLEAN=3D1 >>> >>> Any help is very appreciated. >>> >>> >> What does the following do for you? It's a cut and pasted patch, but it >> should be clear enough what to do if the mailer mangles it. >> >> diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc >> index dd0e242c8ef0..2af4864d8441 100644 >> --- a/lib/libbearssl/Makefile.inc >> +++ b/lib/libbearssl/Makefile.inc >> @@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl >> BEARSSL_SRC=3D ${BEARSSL}/src >> >> CFLAGS+=3D -I${BEARSSL}/inc >> - >> +CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE} >> > > I went ahead and committed this. Please let me know if the problem > persists. > > Warner > >> --000000000000fc378b05f4c2eb78 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Feb 15, 2023, 1:09 PM Mina Gali=C4=87 <freebsd@igalic.co> wrote:
=
Would be nice if we could get upstream to ac= tually fix this, but i don't even know how to submit bugs there=E2=80= =A6

Agreed. I didn't recall off of the top of my head, so I did the quic= k bandaid.=C2=A0

Warner= =C2=A0


= Mina Gali=C4=87


<= br>



-------- Original Message --------
On 15 Feb 2023, 17= :07, Warner Losh < imp@bsdimp.com> wrote:



On Sun, Feb 12, 2023, 3:18 PM Warner Losh <imp@bsdimp.com> wrote:


Hi,

I am currently seeing a build breakage when building -CURRENT with WITH_BEA= RSSL=3D1.

The error is the following

=C2=A0 make[5]: "/boiler/nfs/src/lib/libsecureboot/l= ocal.trust.mk" line 109: warning: "cd /boiler/nfs/src/lib/lib= secureboot && 'ls'=C2=A0 =C2=A0-1 *.pem t*.asc 2> /dev/n= ull" returned non-zero status
=C2=A0 /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: a function declaration without a prototype is deprecat=C2=A0 ed in all v= ersions of C [-Werror,-Wstrict-prototypes]
=C2=A0 br_rsa_i62_keygen_get()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 void
=C2=A0 1 error generated.
=C2=A0 --- rsa_i62_keygen.pico ---


When disabling BEARSSL in the src.conf the build succeeds as usual.

Has anyone also seen this build error. Sources are very recent and the
src.conf is the following:

WITH_EXTRA_TCP_STACKS=3D1
#WITH_BEARSSL=3D1
WITH_PIE=3D1
WITH_RETPOLINE=3D1
WITH_INIT_ALL_ZERO=3D1
WITH_OPENSSL_KTLS=3D1
WITHOUT_CLEAN=3D1

Any help is very appreciated.


What does the following do for you? It= 's a cut and pasted patch, but it should be clear enough what to do if = the mailer mangles it.

diff --git a/lib/libbearssl= /Makefile.inc b/lib/libbearssl/Makefile.inc
index dd0e242c8ef0..2af4864d= 8441 100644
--- a/lib/libbearssl/Makefile.inc
+++ b/lib/libbearssl/Ma= kefile.inc
@@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
=C2= =A0BEARSSL_SRC=3D ${BEARSSL}/src

=C2=A0CFLAGS+=3D -I${BEARSSL}/inc-
+CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}

I went ahead and = committed this. Please let me know if the problem persists.

Warner
--000000000000fc378b05f4c2eb78--