From owner-svn-src-all@freebsd.org  Tue Feb 11 23:11:07 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 81475246213;
 Tue, 11 Feb 2020 23:11:07 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from drew.franken.de (mail-n.franken.de [193.175.24.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "*.franken.de",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48HJRb147sz4mms;
 Tue, 11 Feb 2020 23:11:06 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from [IPv6:2a02:8109:1140:c3d:1161:78c3:3cfb:8c2c] (unknown
 [IPv6:2a02:8109:1140:c3d:1161:78c3:3cfb:8c2c])
 (Authenticated sender: macmic)
 by mail-n.franken.de (Postfix) with ESMTPSA id 248F57213BA4C;
 Wed, 12 Feb 2020 00:11:04 +0100 (CET)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Subject: Re: svn commit: r357761 - head/sys/netinet
From: Michael Tuexen <tuexen@freebsd.org>
In-Reply-To: <20200211195221.GD1351@FreeBSD.org>
Date: Wed, 12 Feb 2020 00:11:03 +0100
Cc: cem@freebsd.org, svn-src-head <svn-src-head@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 src-committers <src-committers@freebsd.org>
Content-Transfer-Encoding: 7bit
Message-Id: <3AB18656-6012-4FFC-AAED-FE08F1B68DFD@freebsd.org>
References: <202002111400.01BE0R3I009898@repo.freebsd.org>
 <CAG6CVpWkvf2JnD=U=dtYgBPjCF59zM40js2uGBCx=OA=EYa8xA@mail.gmail.com>
 <F8AEE0BD-E803-4F80-960B-B7349A4572E5@freebsd.org>
 <20200211195221.GD1351@FreeBSD.org>
To: Gleb Smirnoff <glebius@freebsd.org>
X-Mailer: Apple Mail (2.3608.60.0.2.5)
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
 autolearn=disabled version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de
X-Rspamd-Queue-Id: 48HJRb147sz4mms
X-Spamd-Bar: -
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-1.63 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.94)[-0.944,0];
 ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE];
 NEURAL_HAM_LONG(-0.69)[-0.687,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Feb 2020 23:11:07 -0000

> On 11. Feb 2020, at 20:52, Gleb Smirnoff <glebius@freebsd.org> wrote:
> 
>  Michael,
> 
> On Tue, Feb 11, 2020 at 08:38:21PM +0100, Michael Tuexen wrote:
> M> I can revert it and get it working in a different way. However, the
> M> networking code uses ints for booleans in a lot of places. I wasn't
> M> aware that we need to use bool now.
> 
> We don't need to use bool, but we should use it in any new code.
> Some people may still drop ints into new code, and this can be
> tolerable, but intentionally converting from bools to ints is a
> move backwards and this isn't okay.
Ahh, OK. Thanks for the clarification.

Best regards
Michael
> 
> Thanks for redoing it with via ifdefs for legacy platforms.
> 
> -- 
> Gleb Smirnoff